Hi Alp, Thanks for working on this!
For what I can comment on, i.e., the usage and mapping of the backend generated warning, this looks good to me. Regarding the other parts (demangler, driver, etc.) I leave that to a front-end expert. Thanks, -Quentin On May 30, 2014, at 9:23 AM, Alp Toker <[email protected]> wrote: > The attached patch adds driver and frontend support for the GCC > -Wframe-larger-than=bytes warning. > > As the first GCC-compatible backend diagnostic built around LLVM's reporting > feature the patch adds infrastructure to perform reverse lookup from mangled > names emitted after LLVM code generation. Using that we resolve precise > locations and originating AST functions, lambdas or block declarations to > provide rich codegen-guided diagnostics. > > Supporting changes: > * Get rid of the old MangleBuffer class that was only used for blocks > * Let StringMap maintain unique mangled name strings instead of allocating > copies > > The test intentionally conflates driver, frontend and backend facilities for > now, and I expect parts of the approach to evolve as we get a feel for how > it'll play ball with LTO etc. > > Alp. > > -- > http://www.nuanti.com > the browser experts > > <clang-frame-size-warning.patch>_______________________________________________ > cfe-commits mailing list > [email protected] > http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
_______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
