I see that the current build of sanitizer-x86_64-linux-bootstrap has reached the 'check-all stage3/asan' step without failing so it appears you fixed that too. Thanks.
Having looked at the sanitizer-x86_64-linux-bootstrap failure I think I now understand the clang-i686-msc17-R one and why the fix works. There was a use of an uninitialized value. > -----Original Message----- > From: [email protected] [mailto:cfe-commits- > [email protected]] On Behalf Of Daniel Sanders > Sent: 25 June 2014 10:31 > To: Simon Atanasyan; Reid Kleckner > Cc: [email protected] cfe > Subject: RE: r211619 - [Driver][Mips] Support mips64-linux-gnuabi64 / > mips64el-linux-gnuabi64 target triples. > > Sorry for the breakage and thanks for fixing it. I was about to revert r211598 > that since sanitizer-x86_64-linux-bootstrap failed late last night too. > Seeing as > there's now a chain of commits to revert I'll quickly see if that's an easy > fix > first. > > I feel like I'm missing something obvious here because I don't see how ninja- > clang-i686-msc17-R ended up with an empty string nor how returning the > same string as a constant string fixes the problem. Can someone tell me what > I'm missing? > > > -----Original Message----- > > From: [email protected] [mailto:cfe-commits- > > [email protected]] On Behalf Of Simon Atanasyan > > Sent: 25 June 2014 06:13 > > To: Reid Kleckner > > Cc: [email protected] cfe > > Subject: Re: r211619 - [Driver][Mips] Support mips64-linux-gnuabi64 / > > mips64el-linux-gnuabi64 target triples. > > > > In fact the bug was introduced by r211598. Anyway it is my bad because > > I was reviewer of that change. The r211663,r211665 should fix this problem. > > > > On Wed, Jun 25, 2014 at 3:50 AM, Reid Kleckner <[email protected]> wrote: > > > This test fails for me on Windows, and you can see the failure here: > > > http://bb.pgr.jp/builders/ninja-clang-i686-msc17-R/builds/9035 > > > > [...] > > > > > On Tue, Jun 24, 2014 at 12:00 PM, Simon Atanasyan > > > <[email protected]> > > > wrote: > > >> > > >> Author: atanasyan > > >> Date: Tue Jun 24 14:00:12 2014 > > >> New Revision: 211619 > > >> > > >> URL: http://llvm.org/viewvc/llvm-project?rev=211619&view=rev > > >> Log: > > >> [Driver][Mips] Support mips64-linux-gnuabi64 / > > >> mips64el-linux-gnuabi64 target triples. > > > > -- > > Simon Atanasyan > > _______________________________________________ > > cfe-commits mailing list > > [email protected] > > http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits > > _______________________________________________ > cfe-commits mailing list > [email protected] > http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
