On Feb 6, 2008, at 12:20 AM, Eli Friedman wrote: > On Feb 4, 2008 5:54 PM, Steve Naroff <[EMAIL PROTECTED]> wrote: >> I think it would be a bit cleaner to fold the getTypeForMemberExpr() >> logic into Sema::ActOnMemberReferenceExpr() and pass in the derived >> type explicitly (just add an argument to the constructor). Passing >> the >> type in explicitly is more consistent with all the other expr AST's. > > So, more like the attached? >
Exactly. Looks great. Please add a test for this bug/patch and commit. Thanks, snaroff > -Eli > <memberexprfix.txt> _______________________________________________ cfe-dev mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-dev
