On Sun, Apr 7, 2013 at 11:30 AM, John Keeping <j...@keeping.me.uk> wrote: > const char *cgit_hosturl() > { > + struct strbuf sb = STRBUF_INIT; > if (ctx.env.http_host) > return ctx.env.http_host; > if (!ctx.env.server_name) > return NULL; > if (!ctx.env.server_port || atoi(ctx.env.server_port) == 80) > return ctx.env.server_name; > - return xstrdup(fmt("%s:%s", ctx.env.server_name, > ctx.env.server_port)); > + strbuf_addf(&sb, "%s:%s", ctx.env.server_name, ctx.env.server_port); > + return strbuf_detach(&sb, NULL); > }
Constness issues, since we're going to want to perhaps deallocate this at some point? _______________________________________________ cgit mailing list cgit@hjemli.net http://hjemli.net/mailman/listinfo/cgit