On Sun, Apr 07, 2013 at 04:43:26PM +0100, John Keeping wrote:
> On Sun, Apr 07, 2013 at 05:21:28PM +0200, Jason A. Donenfeld wrote:
> > On Sun, Apr 7, 2013 at 4:26 PM, John Keeping <j...@keeping.me.uk> wrote:
> > > const char *cgit_hosturl()
> > > {
> > > + struct strbuf sb = STRBUF_INIT;
> >
> > This is now unused.
>
> Thanks. Fixed and pushed to my GitHub repository [1]. I'll avoid
> sending another reroll of the entire series and only send incremental
> patches here if nothing serious is found.
Note that you added the patch history to some of the commit messages for
some reason...
>
> [1] http://github.com/johnkeeping/cgit
>
> > > if (ctx.env.http_host)
> > > return ctx.env.http_host;
> > > if (!ctx.env.server_name)
> > > return NULL;
> > > if (!ctx.env.server_port || atoi(ctx.env.server_port) == 80)
> > > return ctx.env.server_name;
> > > - return xstrdup(fmt("%s:%s", ctx.env.server_name,
> > > ctx.env.server_port));
> > > + return fmtalloc("%s:%s", ctx.env.server_name,
> > > ctx.env.server_port);
> > > }
>
> _______________________________________________
> cgit mailing list
> cgit@hjemli.net
> http://hjemli.net/mailman/listinfo/cgit
_______________________________________________
cgit mailing list
cgit@hjemli.net
http://hjemli.net/mailman/listinfo/cgit
