On Mon, Apr 8, 2013 at 9:44 PM, John Keeping <j...@keeping.me.uk> wrote: > > Looks sensible, but I don't think it's quite guaranteed to do what you > want, since Git can call git_config at any time and it re-reads the > files whenever it does. We may not be doing anything that causes it to > be reparsed now, but will we notice if that changes?
Test case time! > > Is there any reason not to leave $HOME and $XDG_CONFIG_HOME unset? Yes. Various parts of cgit shell out to scripts -- filters etc -- and these scripts may very much benefit from having a $HOME. > I don't know how closely you think CGit should stick to that style > though. Actually, to date, cgit has been using /* Comments that * are like this. */ as well as /* * Comments that * are like this. */ as well as // comments that // are like this. the last of which is pretty gross. At some point I'll have to clean up and normalize all of these. _______________________________________________ cgit mailing list cgit@hjemli.net http://hjemli.net/mailman/listinfo/cgit