On Wed, Apr 10, 2013 at 02:16:44PM +0200, Jason A. Donenfeld wrote: > On Wed, Apr 10, 2013 at 2:11 PM, John Keeping <j...@keeping.me.uk> wrote: > > Without '&&' between operations, we will not detect if strace or cgit > > exit with an error status, which would cause a false positive test > > status in this case. > > I wonder if for some of the larger && chains in other tests "set -e" > would be a bit cleaner. I don't know if setting that inside the test > string will bubble the setting back up to the test harness (which > would be bad) or if it would be local for the test (which would be > ideal). Something to investigate.
I expect if it was that easy, the tests in Git would take an approach more like that. Personally, I have found in the past that using "set -e" often leads to problems later on, so I would prefer to keep the &&-chain. _______________________________________________ cgit mailing list cgit@hjemli.net http://hjemli.net/mailman/listinfo/cgit