Changeset: 2dc351726790 for MonetDB
URL: http://dev.monetdb.org/hg/MonetDB?cmd=changeset;node=2dc351726790
Modified Files:
        sql/src/backends/monet5/vaults/fits.mx
Branch: default
Log Message:

Fixed compiler errors.
fits.mx:344: error: ‘v’ may be used uninitialized in this function
fits.mx:345: error: ‘tmp’ may be used uninitialized in this function
fits.mx:224: error: ‘tname_low’ may be used uninitialized in this function

The first two are clear cases of the compiler not doing a full
analysis, but I'm not so sure about the tname_low case.  Please check!


diffs (32 lines):

diff -r 0b2be9b90bbf -r 2dc351726790 sql/src/backends/monet5/vaults/fits.mx
--- a/sql/src/backends/monet5/vaults/fits.mx    Wed Dec 15 23:34:52 2010 +0100
+++ b/sql/src/backends/monet5/vaults/fits.mx    Thu Dec 16 11:36:28 2010 +0100
@@ -221,7 +221,7 @@
        fitsfile *fptr;  /* pointer to the FITS file */
        int status = 0, i, j, hdutype, hdunum = 1, cnum = 0;
        oid  fid, tid, cid, rid = oid_nil;
-       char tname[BUFSIZ], *tname_low, *s, bname[BUFSIZ], stmt[BUFSIZ];
+       char tname[BUFSIZ], *tname_low = NULL, *s, bname[BUFSIZ], stmt[BUFSIZ];
        long tbcol;
        char cname[BUFSIZ], tform[BUFSIZ], tunit[BUFSIZ], tnull[BUFSIZ], 
tdisp[BUFSIZ];
        double tscal, tzero;
@@ -341,8 +341,8 @@
        int status = 0, cnum = 0, fid, hdu, hdutype, i, j, anynull, mtype;
        int *tpcode = NULL;
        long *rep=NULL, *wid=NULL, rows;
-       char keywrd[80], **cname, **v, nm[FLEN_VALUE];
-       BAT *b, *tmp;
+       char keywrd[80], **cname, **v = NULL, nm[FLEN_VALUE];
+       BAT *b, *tmp = NULL;
        ptr nilptr;
        
 
@@ -441,7 +441,7 @@
                        msg = createException(MAL, "fits.loadtable", "Cannot 
load column %s of %s table: %s.\n", cname[j-1], tname, buf);
                        /*      GDKfree(v); */
                        goto finish;
-        }
+               }
 
                col = mvc_bind_column(m, tbl, cname[j-1]);
                if (mtype != TYPE_str ){
_______________________________________________
Checkin-list mailing list
[email protected]
http://mail.monetdb.org/mailman/listinfo/checkin-list

Reply via email to