Changeset: ee5df35d5a64 for MonetDB
URL: http://dev.monetdb.org/hg/MonetDB?cmd=changeset;node=ee5df35d5a64
Modified Files:
        clients/mapiclient/dump.c
Branch: default
Log Message:

Reformatted embedded SQL queries.


diffs (truncated from 858 to 300 lines):

diff --git a/clients/mapiclient/dump.c b/clients/mapiclient/dump.c
--- a/clients/mapiclient/dump.c
+++ b/clients/mapiclient/dump.c
@@ -80,7 +80,7 @@ get_schema(Mapi mid)
        char *sname = NULL;
        MapiHdl hdl;
 
-       if ((hdl = mapi_query(mid, "SELECT \"current_schema\"")) == NULL || 
mapi_error(mid))
+       if ((hdl = mapi_query(mid, "SELECT current_schema")) == NULL || 
mapi_error(mid))
                goto bailout;
        while ((mapi_fetch_row(hdl)) != 0) {
                sname = mapi_fetch_field(hdl, 0);
@@ -115,12 +115,12 @@ has_systemfunctions(Mapi mid)
        int ret;
 
        if ((hdl = mapi_query(mid,
-                             "SELECT \"t\".\"id\" "
-                             "FROM \"sys\".\"_tables\" \"t\","
-                                  "\"sys\".\"schemas\" \"s\" "
-                             "WHERE \"t\".\"name\" = 'systemfunctions' AND "
-                                   "\"t\".\"schema_id\" = \"s\".\"id\" AND "
-                                   "\"s\".\"name\" = 'sys'")) == NULL ||
+                             "SELECT t.id "
+                             "FROM sys._tables t, "
+                                  "sys.schemas s "
+                             "WHERE t.name = 'systemfunctions' AND "
+                                   "t.schema_id = s.id AND "
+                                   "s.name = 'sys'")) == NULL ||
            mapi_error(mid))
                goto bailout;
        ret = mapi_get_row_count(hdl) == 1;
@@ -157,92 +157,92 @@ dump_foreign_keys(Mapi mid, const char *
                maxquerylen = 1024 + strlen(tname) + strlen(schema);
                query = malloc(maxquerylen);
                snprintf(query, maxquerylen,
-                        "SELECT \"ps\".\"name\","              /* 0 */
-                               "\"pkt\".\"name\","             /* 1 */
-                               "\"pkkc\".\"name\","            /* 2 */
-                               "\"fkkc\".\"name\","            /* 3 */
-                               "\"fkkc\".\"nr\","              /* 4 */
-                               "\"fkk\".\"name\","             /* 5 */
-                               "\"fkk\".\"action\","           /* 6 */
-                               "\"fs\".\"name\","              /* 7 */
-                               "\"fkt\".\"name\" "             /* 8 */
-                        "FROM \"sys\".\"_tables\" \"fkt\","
-                             "\"sys\".\"objects\" \"fkkc\","
-                             "\"sys\".\"keys\" \"fkk\","
-                             "\"sys\".\"_tables\" \"pkt\","
-                             "\"sys\".\"objects\" \"pkkc\","
-                             "\"sys\".\"keys\" \"pkk\","
-                             "\"sys\".\"schemas\" \"ps\","
-                             "\"sys\".\"schemas\" \"fs\" "
-                        "WHERE \"fkt\".\"id\" = \"fkk\".\"table_id\" AND "
-                              "\"pkt\".\"id\" = \"pkk\".\"table_id\" AND "
-                              "\"fkk\".\"id\" = \"fkkc\".\"id\" AND "
-                              "\"pkk\".\"id\" = \"pkkc\".\"id\" AND "
-                              "\"fkk\".\"rkey\" = \"pkk\".\"id\" AND "
-                              "\"fkkc\".\"nr\" = \"pkkc\".\"nr\" AND "
-                              "\"pkt\".\"schema_id\" = \"ps\".\"id\" AND "
-                              "\"fkt\".\"schema_id\" = \"fs\".\"id\" AND "
-                              "\"fs\".\"name\" = '%s' AND "
-                              "\"fkt\".\"name\" = '%s'"
-                        "ORDER BY \"fkk\".\"name\", \"nr\"", schema, tname);
+                        "SELECT ps.name, "             /* 0 */
+                               "pkt.name, "            /* 1 */
+                               "pkkc.name, "           /* 2 */
+                               "fkkc.name, "           /* 3 */
+                               "fkkc.nr, "             /* 4 */
+                               "fkk.name, "            /* 5 */
+                               "fkk.\"action\", "      /* 6 */
+                               "fs.name, "             /* 7 */
+                               "fkt.name "             /* 8 */
+                        "FROM sys._tables fkt, "
+                             "sys.objects fkkc, "
+                             "sys.keys fkk, "
+                             "sys._tables pkt, "
+                             "sys.objects pkkc, "
+                             "sys.keys pkk, "
+                             "sys.schemas ps, "
+                             "sys.schemas fs "
+                        "WHERE fkt.id = fkk.table_id AND "
+                              "pkt.id = pkk.table_id AND "
+                              "fkk.id = fkkc.id AND "
+                              "pkk.id = pkkc.id AND "
+                              "fkk.rkey = pkk.id AND "
+                              "fkkc.nr = pkkc.nr AND "
+                              "pkt.schema_id = ps.id AND "
+                              "fkt.schema_id = fs.id AND "
+                              "fs.name = '%s' AND "
+                              "fkt.name = '%s' "
+                        "ORDER BY fkk.name, nr", schema, tname);
        } else if (tid != NULL) {
                maxquerylen = 1024;
                query = malloc(maxquerylen);
                snprintf(query, maxquerylen,
-                        "SELECT \"ps\".\"name\","              /* 0 */
-                               "\"pkt\".\"name\","             /* 1 */
-                               "\"pkkc\".\"name\","            /* 2 */
-                               "\"fkkc\".\"name\","            /* 3 */
-                               "\"fkkc\".\"nr\","              /* 4 */
-                               "\"fkk\".\"name\","             /* 5 */
-                               "\"fkk\".\"action\","           /* 6 */
-                               "0,"                            /* 7 */
-                               "\"fkt\".\"name\" "             /* 8 */
-                        "FROM \"sys\".\"_tables\" \"fkt\","
-                             "\"sys\".\"objects\" \"fkkc\","
-                             "\"sys\".\"keys\" \"fkk\","
-                             "\"sys\".\"_tables\" \"pkt\","
-                             "\"sys\".\"objects\" \"pkkc\","
-                             "\"sys\".\"keys\" \"pkk\","
-                             "\"sys\".\"schemas\" \"ps\""
-                        "WHERE \"fkt\".\"id\" = \"fkk\".\"table_id\" AND "
-                              "\"pkt\".\"id\" = \"pkk\".\"table_id\" AND "
-                              "\"fkk\".\"id\" = \"fkkc\".\"id\" AND "
-                              "\"pkk\".\"id\" = \"pkkc\".\"id\" AND "
-                              "\"fkk\".\"rkey\" = \"pkk\".\"id\" AND "
-                              "\"fkkc\".\"nr\" = \"pkkc\".\"nr\" AND "
-                              "\"pkt\".\"schema_id\" = \"ps\".\"id\" AND "
-                              "\"fkt\".\"id\" = %s"
-                        "ORDER BY \"fkk\".\"name\", \"nr\"", tid);
+                        "SELECT ps.name, "             /* 0 */
+                               "pkt.name, "            /* 1 */
+                               "pkkc.name, "           /* 2 */
+                               "fkkc.name, "           /* 3 */
+                               "fkkc.nr, "             /* 4 */
+                               "fkk.name, "            /* 5 */
+                               "fkk.\"action\", "      /* 6 */
+                               "0, "                   /* 7 */
+                               "fkt.name "             /* 8 */
+                        "FROM sys._tables fkt, "
+                             "sys.objects fkkc, "
+                             "sys.keys fkk, "
+                             "sys._tables pkt, "
+                             "sys.objects pkkc, "
+                             "sys.keys pkk, "
+                             "sys.schemas ps "
+                        "WHERE fkt.id = fkk.table_id AND "
+                              "pkt.id = pkk.table_id AND "
+                              "fkk.id = fkkc.id AND "
+                              "pkk.id = pkkc.id AND "
+                              "fkk.rkey = pkk.id AND "
+                              "fkkc.nr = pkkc.nr AND "
+                              "pkt.schema_id = ps.id AND "
+                              "fkt.id = %s "
+                        "ORDER BY fkk.name, nr", tid);
        } else {
-               query = "SELECT \"ps\".\"name\","               /* 0 */
-                              "\"pkt\".\"name\","              /* 1 */
-                              "\"pkkc\".\"name\","             /* 2 */
-                              "\"fkkc\".\"name\","             /* 3 */
-                              "\"fkkc\".\"nr\","               /* 4 */
-                              "\"fkk\".\"name\","              /* 5 */
-                              "\"fkk\".\"action\","            /* 6 */
-                              "\"fs\".\"name\","               /* 7 */
-                              "\"fkt\".\"name\" "              /* 8 */
-                       "FROM \"sys\".\"_tables\" \"fkt\","
-                            "\"sys\".\"objects\" \"fkkc\","
-                            "\"sys\".\"keys\" \"fkk\","
-                            "\"sys\".\"_tables\" \"pkt\","
-                            "\"sys\".\"objects\" \"pkkc\","
-                            "\"sys\".\"keys\" \"pkk\","
-                            "\"sys\".\"schemas\" \"ps\","
-                            "\"sys\".\"schemas\" \"fs\" "
-                       "WHERE \"fkt\".\"id\" = \"fkk\".\"table_id\" AND "
-                             "\"pkt\".\"id\" = \"pkk\".\"table_id\" AND "
-                             "\"fkk\".\"id\" = \"fkkc\".\"id\" AND "
-                             "\"pkk\".\"id\" = \"pkkc\".\"id\" AND "
-                             "\"fkk\".\"rkey\" = \"pkk\".\"id\" AND "
-                             "\"fkkc\".\"nr\" = \"pkkc\".\"nr\" AND "
-                             "\"pkt\".\"schema_id\" = \"ps\".\"id\" AND "
-                             "\"fkt\".\"schema_id\" = \"fs\".\"id\" AND "
-                             "\"fkt\".\"system\" = FALSE "
-                       "ORDER BY \"fs\".\"name\",\"fkt\".\"name\","
-                             "\"fkk\".\"name\", \"nr\"";
+               query = "SELECT ps.name, "              /* 0 */
+                              "pkt.name, "             /* 1 */
+                              "pkkc.name, "            /* 2 */
+                              "fkkc.name, "            /* 3 */
+                              "fkkc.nr, "              /* 4 */
+                              "fkk.name, "             /* 5 */
+                              "fkk.\"action\", "       /* 6 */
+                              "fs.name, "              /* 7 */
+                              "fkt.name "              /* 8 */
+                       "FROM sys._tables fkt, "
+                            "sys.objects fkkc, "
+                            "sys.keys fkk, "
+                            "sys._tables pkt, "
+                            "sys.objects pkkc, "
+                            "sys.keys pkk, "
+                            "sys.schemas ps, "
+                            "sys.schemas fs "
+                       "WHERE fkt.id = fkk.table_id AND "
+                             "pkt.id = pkk.table_id AND "
+                             "fkk.id = fkkc.id AND "
+                             "pkk.id = pkkc.id AND "
+                             "fkk.rkey = pkk.id AND "
+                             "fkkc.nr = pkkc.nr AND "
+                             "pkt.schema_id = ps.id AND "
+                             "fkt.schema_id = fs.id AND "
+                             "fkt.system = FALSE "
+                       "ORDER BY fs.name,fkt.name, "
+                             "fkk.name, nr";
        }
        hdl = mapi_query(mid, query);
        if (query != NULL && maxquerylen != 0)
@@ -508,33 +508,33 @@ dump_column_definition(Mapi mid, stream 
 
        if (tid)
                snprintf(query, maxquerylen,
-                        "SELECT \"c\".\"name\","               /* 0 */
-                               "\"c\".\"type\","               /* 1 */
-                               "\"c\".\"type_digits\","        /* 2 */
-                               "\"c\".\"type_scale\","         /* 3 */
-                               "\"c\".\"null\","               /* 4 */
-                               "\"c\".\"default\","            /* 5 */
-                               "\"c\".\"number\" "             /* 6 */
-                        "FROM \"sys\".\"_columns\" \"c\" "
-                        "WHERE \"c\".\"table_id\" = %s "
-                        "ORDER BY \"number\"", tid);
+                        "SELECT c.name, "              /* 0 */
+                               "c.type, "              /* 1 */
+                               "c.type_digits, "       /* 2 */
+                               "c.type_scale, "        /* 3 */
+                               "c.\"null\", "          /* 4 */
+                               "c.\"default\", "       /* 5 */
+                               "c.number "             /* 6 */
+                        "FROM sys._columns c "
+                        "WHERE c.table_id = %s "
+                        "ORDER BY number", tid);
        else
                snprintf(query, maxquerylen,
-                        "SELECT \"c\".\"name\","               /* 0 */
-                               "\"c\".\"type\","               /* 1 */
-                               "\"c\".\"type_digits\","        /* 2 */
-                               "\"c\".\"type_scale\","         /* 3 */
-                               "\"c\".\"null\","               /* 4 */
-                               "\"c\".\"default\","            /* 5 */
-                               "\"c\".\"number\" "             /* 6 */
-                        "FROM \"sys\".\"_columns\" \"c\", "
-                             "\"sys\".\"_tables\" \"t\", "
-                             "\"sys\".\"schemas\" \"s\" "
-                        "WHERE \"c\".\"table_id\" = \"t\".\"id\" "
-                        "AND '%s' = \"t\".\"name\" "
-                        "AND \"t\".\"schema_id\" = \"s\".\"id\" "
-                        "AND \"s\".\"name\" = '%s' "
-                        "ORDER BY \"number\"", tname, schema);
+                        "SELECT c.name, "              /* 0 */
+                               "c.type, "              /* 1 */
+                               "c.type_digits, "       /* 2 */
+                               "c.type_scale, "        /* 3 */
+                               "c.\"null\", "          /* 4 */
+                               "c.\"default\", "       /* 5 */
+                               "c.number "             /* 6 */
+                        "FROM sys._columns c, "
+                             "sys._tables t, "
+                             "sys.schemas s "
+                        "WHERE c.table_id = t.id AND "
+                              "'%s' = t.name AND "
+                              "t.schema_id = s.id AND "
+                              "s.name = '%s' "
+                        "ORDER BY number", tname, schema);
        if ((hdl = mapi_query(mid, query)) == NULL || mapi_error(mid))
                goto bailout;
 
@@ -579,33 +579,33 @@ dump_column_definition(Mapi mid, stream 
           constraint */
        if (tid)
                snprintf(query, maxquerylen,
-                        "SELECT \"kc\".\"name\","              /* 0 */
-                               "\"kc\".\"nr\", "               /* 1 */
-                               "\"k\".\"name\", "              /* 2 */
-                               "\"k\".\"id\" "                 /* 3 */
-                        "FROM \"sys\".\"objects\" \"kc\", "
-                             "\"sys\".\"keys\" \"k\" "
-                        "WHERE \"kc\".\"id\" = \"k\".\"id\" AND "
-                              "\"k\".\"table_id\" = %s AND "
-                              "\"k\".\"type\" = 0 "
-                        "ORDER BY \"id\", \"nr\"", tid);
+                        "SELECT kc.name, "             /* 0 */
+                               "kc.nr, "               /* 1 */
+                               "k.name, "              /* 2 */
+                               "k.id "                 /* 3 */
+                        "FROM sys.objects kc, "
+                             "sys.keys k "
+                        "WHERE kc.id = k.id AND "
+                              "k.table_id = %s AND "
+                              "k.type = 0 "
+                        "ORDER BY id, nr", tid);
        else
                snprintf(query, maxquerylen,
-                        "SELECT \"kc\".\"name\","              /* 0 */
-                               "\"kc\".\"nr\", "               /* 1 */
-                               "\"k\".\"name\", "              /* 2 */
-                               "\"k\".\"id\" "                 /* 3 */
-                        "FROM \"sys\".\"objects\" \"kc\", "
-                             "\"sys\".\"keys\" \"k\", "
-                             "\"sys\".\"schemas\" \"s\", "
-                             "\"sys\".\"_tables\" \"t\" "
-                        "WHERE \"kc\".\"id\" = \"k\".\"id\" AND "
-                              "\"k\".\"table_id\" = \"t\".\"id\" AND "
_______________________________________________
checkin-list mailing list
checkin-list@monetdb.org
https://www.monetdb.org/mailman/listinfo/checkin-list

Reply via email to