Changeset: 461fca62fc94 for MonetDB
URL: https://dev.monetdb.org/hg/MonetDB?cmd=changeset;node=461fca62fc94
Modified Files:
        sql/server/rel_schema.c
Branch: remote_auth
Log Message:

Check if the credential registration succeeded

Check that the credential registration succeeded before creating a
remote table and if not, do not create the table.


diffs (18 lines):

diff --git a/sql/server/rel_schema.c b/sql/server/rel_schema.c
--- a/sql/server/rel_schema.c
+++ b/sql/server/rel_schema.c
@@ -947,10 +947,12 @@ rel_create_table(mvc *sql, sql_schema *s
                sql_table *t;
 
                if (tt == tt_remote) {
+                       char *local_user = stack_get_string(sql, 
"current_user");
                        if (!mapiuri_valid(loc))
                                return sql_error(sql, 02, SQLSTATE(42000) 
"CREATE TABLE: incorrect uri '%s' for remote table '%s'", loc, name);
-                       if (AUTHaddRemoteTableCredentials(name, username, 
password, pw_encrypted) != 0) {
-                               return sql_error(sql, 02, SQLSTATE(42000) 
"CREATE TABLE: cannot register credentials for remote table '%s' in vault", 
name);
+                       char *reg_credentials = 
AUTHaddRemoteTableCredentials(loc, local_user, username, password, 
pw_encrypted);
+                       if (reg_credentials != 0) {
+                               return sql_error(sql, 02, SQLSTATE(42000) 
"CREATE TABLE: cannot register credentials for remote table '%s' in vault: %s", 
name, reg_credentials);
                        }
                        t = mvc_create_remote(sql, s, name, SQL_DECLARED_TABLE, 
loc);
                } else {
_______________________________________________
checkin-list mailing list
checkin-list@monetdb.org
https://www.monetdb.org/mailman/listinfo/checkin-list

Reply via email to