Changeset: c995f2b40b4c for MonetDB URL: https://dev.monetdb.org/hg/MonetDB?cmd=changeset;node=c995f2b40b4c Modified Files: sql/test/BugTracker-2018/Tests/multi-column-hash-wrongly-NIL.Bug-6638.sql sql/test/BugTracker-2018/Tests/multi-column-hash-wrongly-NIL.Bug-6638.stable.err sql/test/BugTracker-2018/Tests/multi-column-hash-wrongly-NIL.Bug-6638.stable.out Branch: Mar2018 Log Message:
extended test for bug 6638: multi-column constraint (unique, primary key) checking is also affected; here, the result of mkey.bulk_rotate_xor_hash() is consumed by algebra.thetaselect(), hence, also this one would need to be made to match on NILs (in fact, the C code has this feature; IMHO not triggerable by simple MAL command argument as with algebra.join() ...) diffs (44 lines): diff --git a/sql/test/BugTracker-2018/Tests/multi-column-hash-wrongly-NIL.Bug-6638.sql b/sql/test/BugTracker-2018/Tests/multi-column-hash-wrongly-NIL.Bug-6638.sql --- a/sql/test/BugTracker-2018/Tests/multi-column-hash-wrongly-NIL.Bug-6638.sql +++ b/sql/test/BugTracker-2018/Tests/multi-column-hash-wrongly-NIL.Bug-6638.sql @@ -69,5 +69,9 @@ select * from s9; select * from r9 natural join s9 order by x,y; select * from s9 natural join r9 order by x,y; +alter table r2 add constraint ab_unique unique (a,b); +insert into r2 (a,b) values (2199023255552,0); +select * from r2; + rollback; diff --git a/sql/test/BugTracker-2018/Tests/multi-column-hash-wrongly-NIL.Bug-6638.stable.err b/sql/test/BugTracker-2018/Tests/multi-column-hash-wrongly-NIL.Bug-6638.stable.err --- a/sql/test/BugTracker-2018/Tests/multi-column-hash-wrongly-NIL.Bug-6638.stable.err +++ b/sql/test/BugTracker-2018/Tests/multi-column-hash-wrongly-NIL.Bug-6638.stable.err @@ -28,6 +28,14 @@ stderr of test 'multi-column-hash-wrongl # 16:21:04 > "mclient" "-lsql" "-ftest" "-tnone" "-Eutf-8" "-i" "-e" "--host=/var/tmp/mtest-9105" "--port=34059" # 16:21:04 > +MAPI = (monetdb) /var/tmp/mtest-16700/.s.monetdb.33530 +QUERY = insert into r2 (a,b) values (2199023255552,0); +ERROR = !INSERT INTO: UNIQUE constraint 'r2.ab_unique' violated +CODE = M0M29 +MAPI = (monetdb) /var/tmp/mtest-16700/.s.monetdb.33530 +QUERY = select * from r2; +ERROR = !Current transaction is aborted (please ROLLBACK) +CODE = 25005 # 16:21:04 > # 16:21:04 > "Done." diff --git a/sql/test/BugTracker-2018/Tests/multi-column-hash-wrongly-NIL.Bug-6638.stable.out b/sql/test/BugTracker-2018/Tests/multi-column-hash-wrongly-NIL.Bug-6638.stable.out --- a/sql/test/BugTracker-2018/Tests/multi-column-hash-wrongly-NIL.Bug-6638.stable.out +++ b/sql/test/BugTracker-2018/Tests/multi-column-hash-wrongly-NIL.Bug-6638.stable.out @@ -730,6 +730,9 @@ Ready. [ 0, 0, 0, 0, 0, 0, 72057594037927936, 0, 0, -19, 19 ] [ 0, 0, 0, 0, 0, 0, 0, 72057594037927936, 0, -20, 20 ] [ 0, 0, 0, 0, 0, 0, 0, 0, 72057594037927936, -21, 21 ] +#alter table r2 add contraint ab_unique unique (a,b); +#insert into r2 (a,b) values (2199023255552,0); +#select * from r2; #rollback; # 16:21:04 > _______________________________________________ checkin-list mailing list checkin-list@monetdb.org https://www.monetdb.org/mailman/listinfo/checkin-list
