Changeset: 35cf047fc0d9 for MonetDB URL: https://dev.monetdb.org/hg/MonetDB?cmd=changeset;node=35cf047fc0d9 Modified Files: gdk/gdk_logger.c Branch: Oct2020 Log Message:
Fix unlikely resource leak. diffs (20 lines): diff --git a/gdk/gdk_logger.c b/gdk/gdk_logger.c --- a/gdk/gdk_logger.c +++ b/gdk/gdk_logger.c @@ -1841,8 +1841,14 @@ logger_load(int debug, const char *fn, c #elif defined(HAVE_FSYNC) && fsync(fileno(fp)) < 0 #endif - ) || - fclose(fp) < 0) { + )) { + remove(filename); + (void) fclose(fp); + GDKerror("flushing log file %s failed", + filename); + goto error; + } + if (fclose(fp) < 0) { remove(filename); GDKerror("closing log file %s failed", filename); _______________________________________________ checkin-list mailing list checkin-list@monetdb.org https://www.monetdb.org/mailman/listinfo/checkin-list