Changeset: 24712b73d9b4 for MonetDB
URL: https://dev.monetdb.org/hg/MonetDB/rev/24712b73d9b4
Modified Files:
        sql/storage/bat/bat_storage.c
Branch: default
Log Message:

removed one last usage of bind_col for updates


diffs (32 lines):

diff --git a/sql/storage/bat/bat_storage.c b/sql/storage/bat/bat_storage.c
--- a/sql/storage/bat/bat_storage.c
+++ b/sql/storage/bat/bat_storage.c
@@ -2874,7 +2874,7 @@ static int
 col_stats(sql_trans *tr, sql_column *c, bool *nonil, bool *unique, double 
*unique_est, ValPtr min, ValPtr max)
 {
        int ok = 0;
-       BAT *b = NULL, *off = NULL, *upv = NULL;
+       BAT *b = NULL, *off = NULL;
        sql_delta *d = NULL;
 
        (void) tr;
@@ -2925,17 +2925,8 @@ col_stats(sql_trans *tr, sql_column *c, 
                        }
                        bat_iterator_end(&bi);
                        bat_destroy(b);
-                       if (*nonil && d->cs.ucnt > 0) {
-                               /* This could use a quick descriptor */
-                               if (!(upv = bind_col(tr, c, RD_UPD_VAL)) || 
!(upv = bind_no_view(upv, false))) {
-                                       *nonil = false;
-                               } else {
-                                       MT_lock_set(&upv->theaplock);
-                                       *nonil &= upv->tnonil && !upv->tnil;
-                                       MT_lock_unset(&upv->theaplock);
-                                       bat_destroy(upv);
-                               }
-                       }
+                       if (*nonil && d->cs.ucnt > 0)
+                               *nonil = false;
                }
        }
        return ok;
_______________________________________________
checkin-list mailing list -- [email protected]
To unsubscribe send an email to [email protected]

Reply via email to