Peter Yuen <[email protected]> writes: > so is this function implemented? if so how can we use it ???
Hm, I had forgotten about this approach. Recently, I was asked to clean up the original pull request (which was not per controller, but global), and in doing so, I changed it quite a bit. See https://groups.google.com/forum/#!topic/chicagoboss/c7l-8cJiPN0 So if you have opinions about either approach, post them here or in the other thread, and depending on the community's (and Jesse's) opinions, I'd be happy to make a pull request of modify it either way. - Fredrik > On Tuesday, January 22, 2013 7:52:47 AM UTC+8, Evan Miller wrote: >> >> On Sat, Jan 19, 2013 at 7:47 PM, Fredrik de Vibe >> <[email protected]<javascript:> >> > wrote: >> >>> Fredrik de Vibe <[email protected] <javascript:>> >>> writes: >>> >>> [ --8<-- ] >>> >>> > What about this approach? >>> > >>> > >>> https://github.com/fdevibe/ChicagoBoss/commit/52c764da9e0786697b5e8ca00acfcf9882ae705a >>> >>> ...which was seriously wrong. This one should hopefully be >>> correct-ish: >>> >>> >>> https://github.com/fdevibe/ChicagoBoss/commit/2b5c22aedf41c4efaa8c55accaa26cad0879e1a1 >>> >>> FWIW, I've run some preliminary tests, and I can't see any noticeable >>> performance penalty, at least when it comes to the time it takes to >>> process requests. >>> >> >> I like this. The function might need some more context though, such as >> >> inject_vars_(Action, Method, Tokens, AuthInfo) >> >> That way you could provide log-in information from the before_ filter and >> perform more complex pattern-matching. >> >> What do others think? >> >> Evan -- You received this message because you are subscribed to the Google Groups "ChicagoBoss" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. Visit this group at http://groups.google.com/group/chicagoboss. To view this discussion on the web visit https://groups.google.com/d/msgid/chicagoboss/ygnmbnxdvq7o.fsf%40rubin.ifi.uio.no. For more options, visit https://groups.google.com/d/optout.
