As mentioned in #917, that conditional is in there deliberately because the clang build was observed to break with it in. Felix added it originally when he was building with an ancient clang. When I was getting clang working again, I left it alone because I still saw breakage (or at least it was warning about attribute ignored, I can't remember) when trying to enable it.
Now, I just tested it and it does indeed appear to work with Apple clang 3.1 (xcode 4.3.2). But I don't have the earlier version any more to test with. So I would recommend applying this patch after 4.8.0 and, if someone complains about breakage, we can probably make it conditional on clang version. P.S. This change affects the code output for the better, it's not just aesthetic. On Sep 7, 2012, at 12:29 PM, Mario Domenech Goulart wrote: > On Fri, 7 Sep 2012 19:30:03 +0200 Peter Bex <peter....@xs4all.nl> wrote: > >> On Thu, Sep 06, 2012 at 09:18:38PM -0400, Mario Domenech Goulart wrote: >>> >>> Christian Lask reported on #chicken that make check fails when Chicken >>> is built with clang (see #917). >>> >>> The attached patch seems to fix that problem (tested with clang 3.0). >> >> I wonder if this will work with older versions of Clang >> (notably XCode's). I'm assuming this #ifdef wasn't added just for >> the hell of it. > > Yeah, that's my concern too. > > >>> In the end, it just silents some warnings that break tests that rely on >>> diff. >>> >>> Even if it is the proper fix, feel free to postpone it to after 4.8.0. >> >> Perhaps the best thing to do. > > I agree. > > Mario > -- > http://parenteses.org/mario > > _______________________________________________ > Chicken-hackers mailing list > Chicken-hackers@nongnu.org > https://lists.nongnu.org/mailman/listinfo/chicken-hackers _______________________________________________ Chicken-hackers mailing list Chicken-hackers@nongnu.org https://lists.nongnu.org/mailman/listinfo/chicken-hackers
