i’ll try it, but probably not until the weekend

> On Feb 15, 2023, at 11:15 AM, Mario Domenech Goulart <[email protected]> 
> wrote:
> 
> Hi Josh,
> 
> On Tue, 8 Mar 2022 08:27:41 -0500 josh <[email protected] 
> <mailto:[email protected]>> wrote:
> 
>> Hello there, hope you're all well.
>> 
>> I recently ran into trouble building Chicken on my MacOS system (Big Sur
>> 11.2.3) due to issues with command-line tool paths. There was a change in
>> c6a6a26225620b566f8bc487cc4180de55555a2a that assumed the user has Xcode
>> installed, and that the tools are within /Applications/Xcode.app/.
>> 
>> However, it's possible to install command-line tools on MacOS without Xcode
>> (if one tries to run e.g. `gcc` on a fresh MacOS install you'll be prompted
>> to do so), in which case the Makefile's assumptions are not sufficient. This
>> patch adds a check to see if Xcode is installed, and if not uses the tools
>> in /usr/bin instead.
>> 
>> (Please note that this is my first patch to Chicken, and first patch in
>> general :P, so my apologies if I'm missing anything. I'm also not familiar
>> with GNU's make so I hope the construct I chose is portable enough.)
>> 
>> Thank you all for your time and hard work!
> 
> Thanks for your patch.  Not sure if you got any feedback on it?  If not,
> apologies for the embarrassingly long time to reply.
> 
> The change looks sensible to me, but I don't have an OSX system to test
> it.
> 
> Any takers?
> 
> All the best.
> Mario
> -- 
> http://parenteses.org/mario

Reply via email to