Issue 3039: Crash when adding a new word to the dictionary
http://code.google.com/p/chromium/issues/detail?id=3039
Comment #43 by [EMAIL PROTECTED]:
Okay, I see the problem.
On trunk, the code looks like this:
FILE* f = file_util::OpenFile(file_name_, "a+");
if (f != NULL)
fputs(word_.c_str(), f);
file_util::CloseFile(f);
Reference:
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/spellchecker.cc?revision=3546&view=markup
But in 0.3.154.6, the code looks like this:
FILE* f = fopen(file_name_char, "a+");
if (f != NULL)
fputs(word_.c_str(), f);
fclose(f);
Reference:
http://src.chromium.org/viewvc/chrome/branches/official/build_154.6/src/chrome/browser/spellchecker.cc?revision=3975&view=markup
The difference being that on trunk we use file_util::CloseFile, which now
does a null
check before calling fclose, but on the release branch we call fclose
directly, so we
don't get the null check. We'll have to get this remedied on the release
branch.
--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"Chromium-bugs" group.
To post to this group, send email to chromium-bugs@googlegroups.com
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at
http://groups.google.com/group/chromium-bugs?hl=en
-~----------~----~----~----~------~----~------~--~---
