Issue 3834: UMR of WebPreferences::dashboard_compatibility_mode when
sending the ViewMsg_New message
http://code.google.com/p/chromium/issues/detail?id=3834
New issue report by [EMAIL PROTECTED]:
Purify reports a UMR of WebPreferences::dashboard_compatibility_mode
when sending the ViewMsg_New message. The reason is that the
WebPreferences constructor doesn't initialize the
dashboard_compatibility_mode member, and WebContents::GetWebkitPrefs()
doesn't set dashboard_compatibility_mode.
The possible fixes are:
- Change the WebPreferences constructor to initialize
dashboard_compatibility_mode.
- Remove the dashboard_compatibility_mode member from the WebPreferences
structure. This member isn't being used, at least on Windows.
Here is the call stack of the UMR from Purify:
[W] UMR: Uninitialized memory read in
IPC::ParamTraits<bool>::Write(Message::IPC *,bool const&) {1 occurrence}
Reading 1 byte from 0x0013bced (1 byte at 0x0013bced uninitialized)
Address 0x0013bced points into a thread's stack
Address 0x0013bced is 233 bytes past the start of local variable
'this' in ViewMsg_New::ViewMsg_New(HWND__ * const const&,void * const
const&,WebPreferences const&,int const&)
Thread ID: 0xbc8
Error location
IPC::ParamTraits<bool>::Write(Message::IPC *,bool const&)
[c:\chrome1\src\chrome\common\ipc_message_utils.h:112]
struct ParamTraits<bool> {
typedef bool param_type;
static void Write(Message* m, const param_type& p) {
=> m->WriteBool(p);
}
static bool Read(const Message* m, void** iter,
param_type* r) {
return m->ReadBool(iter, r);
IPC::WriteParam<bool>
[c:\chrome1\src\chrome\common\ipc_message_utils.h:95]
IPC::ParamTraits<WebPreferences>::Write(Message::IPC
*,WebPreferences const&)
[c:\chrome1\src\chrome\common\render_messages.h:1585]
WriteParam(m, p.shrinks_standalone_images_to_fit);
WriteParam(m, p.uses_universal_detector);
WriteParam(m, p.text_areas_are_resizable);
=> WriteParam(m, p.dashboard_compatibility_mode);
WriteParam(m, p.java_enabled);
WriteParam(m, p.user_style_sheet_enabled);
WriteParam(m, p.user_style_sheet_location);
IPC::WriteParam<WebPreferences>
[c:\chrome1\src\chrome\common\ipc_message_utils.h:95]
IPC::ParamTraits<Tuple4<HWND__ *,void
*,WebPreferences,int>>::Write(Message::IPC *,Tuple4<HWND__ *,void
*,WebPreferences,int> const&)
[c:\chrome1\src\chrome\common\ipc_message_utils.h:896]
IPC::WriteParam<Tuple4<HWND__ *,void *,WebPreferences,int> >
[c:\chrome1\src\chrome\common\ipc_message_utils.h:95]
IPC::MessageWithTuple<Tuple4<HWND__ *,void
*,WebPreferences,int>>::MessageWithTuple<Tuple4<HWND__ *,void
*,WebPreferences,int>>(int,WORD,Tuple4<HWND__ *,void *,WebPreferences,int>
const&) [c:\chrome1\src\chrome\common\ipc_message_utils.h:998]
ViewMsg_New::ViewMsg_New(HWND__ * const const&,void * const
const&,WebPreferences const&,int const&)
[c:\chrome1\src\chrome\common\render_messages_internal.h:40]
RenderViewHost::CreateRenderView(void)
[c:\chrome1\src\chrome\browser\render_view_host.cc:148]
Send(new ViewMsg_New(view_->GetPluginHWND(),
modal_dialog_event,
delegate_->GetWebkitPrefs(),
=> routing_id_));
// Set the alternate error page, which is profile
specific, in the renderer.
GURL url = delegate_->GetAlternateErrorPageURL();
WebContents::CreateRenderViewForRenderManager(RenderViewHost *)
[c:\chrome1\src\chrome\browser\web_contents.cc:1361]
Issue attributes:
Status: Untriaged
Owner: [EMAIL PROTECTED]
Labels: Type-Bug Pri-2 OS-All Area-Misc
--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"Chromium-bugs" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at
http://groups.google.com/group/chromium-bugs?hl=en
-~----------~----~----~----~------~----~------~--~---
