Comment #4 on issue 4714 by [EMAIL PROTECTED]: Browser crashes in FocusManager::OnNCDestroy in 154.23 http://code.google.com/p/chromium/issues/detail?id=4714
In an attempt to mitigate potential crashers, I landed a change that makes sure the focus manager does not subclass a window more than once. Today the tab content's window is subclassed more than once, but it is OK as the second subclassing checks if the current WinProc is the same as the new one and does nothing if that's the case. However one could imagine a third-party application (anti-virus, assistive software...) subclassing the window after the focus manager. At that point subsequent subclassing by the focus manager would succeed, causing the stack of WinProc for the window to contain the focus manager's WinProc twice. Looking at the mini-dumps though, I only saw in once a suspicious loaded DLL (AhJsctNs.dll of Avast Antivirus) so I don't think it is going to help with this crasher. Furthermore, if the double subclassing was the problem, one would expect a stack trace like: FocusManager::WinProc ThirdPartyApp:WinProc FocusManager::WinProc ... which is not what we are seeing. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Chromium-bugs" group. To post to this group, send email to chromium-bugs@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/chromium-bugs?hl=en -~----------~----~----~----~------~----~------~--~---
