Comment #13 on issue 1062 by m0.interactive: Middle-click to close tabs  
activates even if mouse-up is not over tab
http://code.google.com/p/chromium/issues/detail?id=1062

Alright, then the only way to do this is trying to find the width of the  
current tab ... I managed
to do this by using the TabRenderer class and retrieving the attributes  
stored inside it.

The code is ugly, unless you know a better way to retrieve the width and  
height of the current
tab. There are properties such as:

   // The bounds of various sections of the display.
   gfx::Rect favicon_bounds_;
   gfx::Rect download_icon_bounds_;
   gfx::Rect title_bounds_;

But, only title_bounds contains values, favicon_bounds and  
download_icon_bounds all return 0 for
its width and height. Please review this patch and tell me what you think.  
This is my second patch
for chromium, and I am volunteering to attempt fixing patches so I could  
learn C++ since
university only taught us Java. So bear with me :x

The patch is here:
http://codereview.chromium.org/12816

I tested it and it works "alright" I didn't see any issues.

-- 
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings

--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups 
"Chromium-bugs" group.
To post to this group, send email to chromium-bugs@googlegroups.com
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at 
http://groups.google.com/group/chromium-bugs?hl=en
-~----------~----~----~----~------~----~------~--~---

Reply via email to