Comment #4 on issue 6306 by [email protected]: Chrome: Crash Report -
Stack Signature: -69C09D59
http://code.google.com/p/chromium/issues/detail?id=6306
The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=8578
------------------------------------------------------------------------
r8578 | [email protected] | 2009-01-23 13:05:34 -0800 (Fri, 23 Jan 2009)
| 17 lines
Changed paths:
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/generated_resources.grd?r1=8578&r2=8577
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/browser_resources.h?r1=8578&r2=8577
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/browser_resources.rc?r1=8578&r2=8577
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/resources/browser_resources.vcproj?r1=8578&r2=8577
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/resources/safe_browsing_malware_block.html?r1=8578&r2=8577
A
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/resources/safe_browsing_multiple_threat_block.html
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/resources/safe_browsing_phishing_block.html?r1=8578&r2=8577
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/safe_browsing/safe_browsing_blocking_page.cc?r1=8578&r2=8577
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/safe_browsing/safe_browsing_blocking_page.h?r1=8578&r2=8577
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/safe_browsing/safe_browsing_service.cc?r1=8578&r2=8577
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/safe_browsing/safe_browsing_service.h?r1=8578&r2=8577
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tab_contents/interstitial_page.cc?r1=8578&r2=8577
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tab_contents/interstitial_page.h?r1=8578&r2=8577
This CL makes the safe browsing interstitial page support multiple unsafe
resources in one page.
We had a bug when an interstitial was showing and another unsafe resource
was detected. We would show another interstitial on top of the original
one, causing the DontProceed method to be invoked several times. That would
cause us to remove more than once an entry from the navigation controller
and cause crashers.
With this new CL, if an interstitial shows and a new resource is flagged as
bad, the SafeBrowsingBlockingPage will queue that notification. If the user
decides to proceed through the interstitial, we'll create another
interstitial warning about all the unsafe resources we have received so far.
This CL also contains a fix for a crasher that would happen when closing a
tab with a safe browsing interstitial.
BUG=5916,6207,6306
TEST=Test all actions in the interstitial you get when opening pages with
the followin scenarios:
- Main page is malware
- Main page is fishing
- Main page is OK contains resources (images,iframes...) which are malware
- Main page is OK contains resources (images,iframes...) which are phishing
- Main page is OK contains resources (images,iframes...) some of them
phishing, some of then malware.
Note that when there are more than one bad resource, it is normal to see a
1st interstitial, then another one listing all the other bad resources.
(ex of malware site http://ianfette.org, phishing site
http://cvisit.tripod.com)
Review URL: http://codereview.chromium.org/18346
------------------------------------------------------------------------
--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings
--~--~---------~--~----~------------~-------~--~----~
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/group/chromium-bugs
-~----------~----~----~----~------~----~------~--~---
