Comment #3 on issue 6598 by craig.schlenter: Instead of looping to RLIMIT_NOFILE, find open FDs by looking at /proc/self/fd (Linux) or /dev/fd (Mac) http://code.google.com/p/chromium/issues/detail?id=6598
I have put some initial code here: http://codereview.chromium.org/18801 There are a couple of issues that should be discussed, perhaps as part of the code review: 1. I don't think the casting is wrong per-se in GetMaxFilesOpenInProcess since fds are ints so I haven't removed that function - the unit test uses it too which I didn't change but I can alter or kill that if desired 2. The error handling of my patch could be improved ... The old code ignored fcntl failures but the new code is going to fail for example if proc isn't mounted as well. I haven't added reviewers to the patch yet ... will you review please or suggest someone? Thank you! -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~---------~--~----~------------~-------~--~----~ Automated mail from issue updates at http://crbug.com/ Subscription options: http://groups.google.com/group/chromium-bugs -~----------~----~----~----~------~----~------~--~---
