Status: Available
Owner: jer...@chromium.org
CC: a...@chromium.org,  d...@chromium.org
Labels: Type-Bug Pri-2 OS-Mac Area-Misc

New issue 7146 by jer...@chromium.org: IPC::Channel unit test fails on  
large messages on POSIX
http://code.google.com/p/chromium/issues/detail?id=7146

The following patch causes the IPC::Channel unit tests to fail on the Mac
(possibly Linux too):

Description:
Fix an UMR in IPCChannelTest.ChannelTest (message might have been
much smaller than intended)


Please review this at http://codereview.chromium.org/18845

SVN Base: svn://chrome-svn/chrome/trunk/src/

Affected files:
  M     chrome/common/ipc_tests.cc


Index: chrome/common/ipc_tests.cc
===================================================================
--- chrome/common/ipc_tests.cc  (revision 8654)
+++ chrome/common/ipc_tests.cc  (working copy)
@@ -153,8 +153,9 @@
   message->WriteInt(message_index++);
   message->WriteString(std::string(text));

-  // make sure we can handle large messages
+  // Make sure we can handle large messages.
   char junk[50000];
+  memset(junk, 'a', sizeof(junk)-1);
   junk[sizeof(junk)-1] = 0;

--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings

--~--~---------~--~----~------------~-------~--~----~
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/group/chromium-bugs
-~----------~----~----~----~------~----~------~--~---

Reply via email to