Updates:
        Status: Untriaged
        Owner: w...@chromium.org
        Cc: da...@chromium.org ero...@chromium.org nsylv...@chromium.org
        Labels: -Area-Misc Area-BrowserBackend Regression
        Mergedinto: -19

Comment #23 on issue 6824 by w...@chromium.org: No logon prompt  
for "Integrated Windows Authentication" (NTLM) only sites
http://code.google.com/p/chromium/issues/detail?id=6824

I confirmed that Google Chrome 1.0.154.x supports NTLM
authentication.  I mistakenly thought that we never
supported NTLM, but after consulting the source code
and talking to Nicolas, I found that the only thing we
turned off in 1.0.154.x was automatic NTLM logon;
1.0.154.x still supports NTLM authentication with manual
logon (asking the user for username and password).  The
relevant change was, from our old SVN repository:

Index: http/http_transaction_winhttp.cc
===================================================================
--- http/http_transaction_winhttp.cc    (revision 29763)
+++ http/http_transaction_winhttp.cc    (revision 29764)
@@ -916,10 +916,18 @@

    if (!WinHttpSetOption(request_handle_, WINHTTP_OPTION_DISABLE_FEATURE,
                          &options, sizeof(options))) {
-    DLOG(ERROR) << "WinHttpSetOption failed: " << GetLastError();
+    DLOG(ERROR) << "WinHttpSetOption disable feature failed:" <<  
GetLastError()
;
      return false;
    }

+  // Disable auto-login for Negotiate and NTLM auth methods.
+  DWORD security_level = WINHTTP_AUTOLOGON_SECURITY_LEVEL_HIGH;
+  if (!WinHttpSetOption(request_handle_, WINHTTP_OPTION_AUTOLOGON_POLICY,
+                        &security_level, sizeof(security_level))) {
+    DLOG(ERROR) << "WinHttpSetOption autologon failed: " << GetLastError();
+    return false;
+  }
+
    if (is_https_) {
      // Check SSL server certificate revocation.
      SSLConfig ssl_config;

I'm reopening this bug in the hope that it will stop the
discussion on whether it's the same as issue 19.  What's
important is that we recognize the Dev channel 2.0.x.y
builds have a regression in NTLM authentication support.

--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings

--~--~---------~--~----~------------~-------~--~----~
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/group/chromium-bugs
-~----------~----~----~----~------~----~------~--~---

Reply via email to