Comment #6 on issue 6859 by bugdro...@chromium.org: Focus and shortcuts issues with Gears dialog http://code.google.com/p/chromium/issues/detail?id=6859
The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=9925
------------------------------------------------------------------------
r9925 | jcam...@chromium.org | 2009-02-17 16:46:20 -0800 (Tue, 17 Feb 2009)
| 14 lines
Changed paths:
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/jsmessage_box_handler_win.cc?r1=9925&r2=9924
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/jsmessage_box_handler_win.h?r1=9925&r2=9924
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/dom_view.cc?r1=9925&r2=9924
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/dom_view.h?r1=9925&r2=9924
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/frame/browser_view.cc?r1=9925&r2=9924
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/frame/browser_view.h?r1=9925&r2=9924
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/html_dialog_view.cc?r1=9925&r2=9924
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/html_dialog_view.h?r1=9925&r2=9924
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/new_profile_dialog.cc?r1=9925&r2=9924
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/new_profile_dialog.h?r1=9925&r2=9924
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/options/cookies_view.h?r1=9925&r2=9924
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/select_profile_dialog.cc?r1=9925&r2=9924
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/select_profile_dialog.h?r1=9925&r2=9924
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/views/dialog_delegate.cc?r1=9925&r2=9924
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/views/dialog_delegate.h?r1=9925&r2=9924
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/views/hwnd_view.cc?r1=9925&r2=9924
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/views/hwnd_view.h?r1=9925&r2=9924
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/views/window_delegate.h?r1=9925&r2=9924
HtmlDialogs had focus problems.
They would not be focused when shown and tab traversal was not working.
This was caused by several issues:
- HWNDView was not focusing its HWND when focused through the
View::RequestFocus() method (it would rely on the default view behavior
which is to focus the root view HWND), so it would not be focused by
default.
- DOMView (parent of HtmlDialogView) was not focusable so would not get the
focus when pressing tab.
- DOMView was not eating tab keys events (by returning false in
View::CanProcessTabKeyEvents()), so the render view would not get the tab
key press messages (for focus traversal in the render view).
Note: most of the file changes in this CL are just the consequence of
changing the constness of the WindowDelegate::GetInitiallyFocusedView
method.
BUG=6859
TEST=Open a web page, from the page menu, select the "Create application
shortcut..." menu. In the dialog, press the TAB key, focus should alternate
between the different fields
Review URL: http://codereview.chromium.org/21439
------------------------------------------------------------------------
--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings
--~--~---------~--~----~------------~-------~--~----~
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/group/chromium-bugs
-~----------~----~----~----~------~----~------~--~---
