Comment #2 on issue 7326 by [email protected]: RTL: Folder icon
missing on "Download location" text box
http://code.google.com/p/chromium/issues/detail?id=7326
The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=10121
------------------------------------------------------------------------
r10121 | [email protected] | 2009-02-20 12:42:10 -0800 (Fri, 20 Feb 2009) |
27 lines
Changed paths:
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/bookmarks/bookmark_table_model.cc?r1=10121&r2=10120
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/options/advanced_contents_view.cc?r1=10121&r2=10120
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/options/content_page_view.cc?r1=10121&r2=10120
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/l10n_util.cc?r1=10121&r2=10120
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/l10n_util.h?r1=10121&r2=10120
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/l10n_util_unittest.cc?r1=10121&r2=10120
This CL fix the following 2 bugs:
1.7324 -- RTL: Path contains Hebrew is wrong on "Download location" text box
(http://crbug.com/7324)
2. 7326 -- RTL: Folder icon missing on "Download location" text box
(http://crbug.com/7326)
The fix are:
1. force path to have LTR directionality.
2. draw icon in mirrored position in RTL locales.
Steps for test:
1. Create a folder with a Hebrew file name on Hebrew XP
2. Change the download location to the folder created in step 1
3. Observe the path displayed on "Google Chrome Options" --> "Minor Tweaks"
--> "Download location" text box
Without the fix:
The path contains Hebrew folder name is wrong. It displayed as "cCBA\:"
while the path is "c:\CBA" where "CBA" is a Hebrew folder name.
And there is no folder icon in the "download location" text box.
With the fix:
The path displayed correctly as "c:\CBA" or "c:\CBA\FED" where "FED" is
subfolder of "CBA".
And the folder icon showed at the very right.
Review URL: http://codereview.chromium.org/20038
------------------------------------------------------------------------
--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings
--~--~---------~--~----~------------~-------~--~----~
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/group/chromium-bugs
-~----------~----~----~----~------~----~------~--~---
