Comment #1 on issue 7549 by bugdro...@chromium.org: off-by-1 error in
Windows' fontfallback results in the last font in the font fallback list
not being used
http://code.google.com/p/chromium/issues/detail?id=7549
The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=10203
------------------------------------------------------------------------
r10203 | jungs...@google.com | 2009-02-23 11:39:38 -0800 (Mon, 23 Feb 2009)
| 17 lines
Changed paths:
M
http://src.chromium.org/viewvc/chrome/trunk/deps/third_party/WebKit/WebCore/platform/graphics/FontCache.h?r1=10203&r2=10202
M
http://src.chromium.org/viewvc/chrome/trunk/deps/third_party/WebKit/WebCore/platform/graphics/chromium/FontCacheChromiumWin.cpp?r1=10203&r2=10202
M
http://src.chromium.org/viewvc/chrome/trunk/deps/third_party/WebKit/WebCore/platform/graphics/chromium/FontCacheLinux.cpp?r1=10203&r2=10202
alternateFamilyName customization for Windows was landed in Webkit (r40636,
https://bugs.webkit.org/show_bug.cgi?id=20531). Instead of adding a static
member function
to FontCache class to be implemented in each platform, |
alternateFamilyName| in FontCache.cpp was changed with
#ifdef's for Windows.
This CL make our copy of FontCache.h identical to that of Webkit trunk's.
FontCache.cpp was merged in the latest merge.
It also removes the implementation of alternateFamilyName in
FontCache{ChromiumWin,Linux}.cpp. This part of the
patch was uploaded to webkit bug 20531
(https://bugs.webkit.org/attachment.cgi?id=27486 )
FontCacheChromiumWin.cpp also includes a patch for off-by-1 error (webkit
bug : http://bugs.webkit.org/show_bug.cgi?id=23803). This was not intended,
but the fix is trivial and I'll land it together once the webkit trunk gets
it.
BUG=7549
Review URL: http://codereview.chromium.org/21174
------------------------------------------------------------------------
--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings
--~--~---------~--~----~------------~-------~--~----~
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/group/chromium-bugs
-~----------~----~----~----~------~----~------~--~---
