Comment #6 on issue 7023 by [email protected]: Dragging image results
in whole browser crash
http://code.google.com/p/chromium/issues/detail?id=7023
The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=10206
------------------------------------------------------------------------
r10206 | [email protected] | 2009-02-23 12:14:41 -0800 (Mon, 23 Feb 2009) | 20
lines
Changed paths:
M
http://src.chromium.org/viewvc/chrome/trunk/deps/third_party/WebKit/WebCore/platform/chromium/ClipboardChromium.cpp?r1=10206&r2=10205
M
http://src.chromium.org/viewvc/chrome/trunk/deps/third_party/WebKit/WebCore/platform/chromium/ClipboardChromium.h?r1=10206&r2=10205
A
http://src.chromium.org/viewvc/chrome/trunk/deps/third_party/WebKit/WebCore/platform/chromium/ClipboardChromiumLinux.cpp
A
http://src.chromium.org/viewvc/chrome/trunk/deps/third_party/WebKit/WebCore/platform/chromium/ClipboardChromiumMac.cpp
A
http://src.chromium.org/viewvc/chrome/trunk/deps/third_party/WebKit/WebCore/platform/chromium/ClipboardChromiumWin.cpp
M
http://src.chromium.org/viewvc/chrome/trunk/src/webkit/build/WebCore/SConscript?r1=10206&r2=10205
M
http://src.chromium.org/viewvc/chrome/trunk/src/webkit/build/WebCore/WebCore.vcproj?r1=10206&r2=10205
M
http://src.chromium.org/viewvc/chrome/trunk/src/webkit/webkit.xcodeproj/project.pbxproj?r1=10206&r2=10205
I'm expanding this to fix a couple of bugs in determining the file name for
dragging images:
. It's possible for the extension to be empty, resulting in a bad file
name, for example, 'foo.' or just '.'.
. We weren't restricting the size of the file to MAX_PATH.
. We weren't removing characters that are invalid for file system names.
It's possible to put this code up in OSExchangeData rather than
here, but it feels best to centralize it here so that we don't have to
worry about bad file names leaking into other code.
I tried hard to write a layout test for this, but it seems we don't
really use the file name in test shell so that I couldn't get
coverage.
BUG=7023
TEST=none
Review URL: http://codereview.chromium.org/20504
------------------------------------------------------------------------
--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings
--~--~---------~--~----~------------~-------~--~----~
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/group/chromium-bugs
-~----------~----~----~----~------~----~------~--~---
