Comment #32 on issue 1845 by hb...@chromium.org: cant alignt text to the  
right using right shift and right ctrl
http://code.google.com/p/chromium/issues/detail?id=1845

Hi Jeremy,

Sorry for the lack of my updates.

Even though I have a "partial" fix for this, I'm wondering about the  
behavior when we "undo" changing the writing direction of a
textarea.
Currently, my fix uses functions in "WebCore/editing/EditorgCommand.cpp",  
which support undos, i.e. when we press control-z after
changing the writing direction of a textarea to RTL, the writing direction  
become back to LTR.
On the other hand, to check the behavior of IE, IE ignores undos, i.e. even  
when we press control-z after changing the writing direction
of a textarea to RTL, the writing direction is still RTL.

The former implementation requires a change to WebKit, but the latter does  
not. (The latter only needs a change in our
EditorClientImpl::handleEditingKeyboardEvent() function that calls the  
Editor::setBaseWritingDirection() function.) It seemed Mitz
recommended to use the latter option  
in "https://bugs.webkit.org/show_bug.cgi?id=23156";.

Is it possible to give me your idea about which behavior is the better  
option?

Regards,

Hironori Bono

--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings

--~--~---------~--~----~------------~-------~--~----~
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/group/chromium-bugs
-~----------~----~----~----~------~----~------~--~---

Reply via email to