Comment #1 on issue 8811 by [email protected]:  
ProcessUtilTest.KillSlowChild is flaky
http://code.google.com/p/chromium/issues/detail?id=8811

The following revision refers to this bug:
     http://src.chromium.org/viewvc/chrome?view=rev&revision=11728

------------------------------------------------------------------------
r11728 | [email protected] | 2009-03-16 06:43:10 -0700 (Mon, 16 Mar  
2009) | 14 lines
Changed paths:
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/base/process_util_unittest.cc?r1=11728&r2=11727

This should make ProcessUtilTest.KillSlowChild not-flaky.

There is no need to check process count (which tends to induce flakiness).
In fact, we are already checking all important facts:

- after checking that process handle is a not-null handle we know
   that the process started successfully

- after WaitForSingleProcess returns true we know that the process
   finished successfully

BUG=8811

Review URL: http://codereview.chromium.org/42224
------------------------------------------------------------------------


--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings

--~--~---------~--~----~------------~-------~--~----~
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/group/chromium-bugs
-~----------~----~----~----~------~----~------~--~---

Reply via email to