Comment #3 on issue 9227 by [email protected]: DCHECK in
ResolveProxyMsgHelperTest on POSIX
http://code.google.com/p/chromium/issues/detail?id=9227
The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=12356
------------------------------------------------------------------------
r12356 | [email protected] | 2009-03-24 07:28:46 -0700 (Tue, 24 Mar
2009) | 24 lines
Changed paths:
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/net/resolve_proxy_msg_helper_unittest.cc?r1=12356&r2=12355
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sessions/tab_restore_service_unittest.cc?r1=12356&r2=12355
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/chrome.gyp?r1=12356&r2=12355
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/unit/unit_tests.scons?r1=12356&r2=12355
Porting of unit tests in chrome/
- enable following tests on Linux:
browser/net/resolve_proxy_msg_helper_unittest.cc
browser/profile_manager_unittest.cc
browser/sessions/tab_restore_service_unittest.cc
common/time_format_unittest.cc
- sync chrome.gyp
- fix a bug in resolve_proxy_msg_helper_unittest that triggered
a DCHECK on POSIX.
It freed the WaitableEvent too early because Wait in dtor
was effectively a noop because the event was already in signaled
state from previous operations and a manual-reset flag was set.
The fix was to put the WaitableEvent in automatic reset mode.
- misc GCC-related cleanups
http://crbug.com/9227
Review URL: http://codereview.chromium.org/53007
------------------------------------------------------------------------
--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings
--~--~---------~--~----~------------~-------~--~----~
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/group/chromium-bugs
-~----------~----~----~----~------~----~------~--~---
