Comment #2 on issue 9253 by [email protected]: REGRESSION: native
buttons cannot get focus through tab traversal
http://code.google.com/p/chromium/issues/detail?id=9253
The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=12420
------------------------------------------------------------------------
r12420 | [email protected] | 2009-03-24 17:11:44 -0700 (Tue, 24 Mar
2009) | 8 lines
Changed paths:
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/views/controls/button/native_button.cc?r1=12420&r2=12419
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/views/controls/button/native_button.h?r1=12420&r2=12419
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/views/controls/button/native_button_win.cc?r1=12420&r2=12419
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/views/controls/button/native_button_win.h?r1=12420&r2=12419
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/views/controls/button/native_button_wrapper.h?r1=12420&r2=12419
Focusing a native button through a RequestFocus call would not result in
the actual button showing as focused.
This is because the NativeButton is the one getting focused not the
NativeControl wrapper.
This CL adds forwarding the focus to the NativeControl so the HWND really
gets focused.
It also associates the NativeButton view with the NativeControl, so that
when the HWND is focused (through a click for example), the focus manager
has the NativeButton as the focused view (not the NativeControl wrapper).
BUG=9253
TEST=Open the option panel. Press tab several times. The focus should move
as expected to the different buttons and views in the page.
Review URL: http://codereview.chromium.org/45042
------------------------------------------------------------------------
--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings
--~--~---------~--~----~------------~-------~--~----~
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/group/chromium-bugs
-~----------~----~----~----~------~----~------~--~---
