Comment #8 on issue 6450 by bugdro...@chromium.org: Cookies set during a 401 are not applied to the restarted transaction http://code.google.com/p/chromium/issues/detail?id=6450
The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=12635
------------------------------------------------------------------------
r12635 | ericro...@google.com | 2009-03-26 21:00:22 -0700 (Thu, 26 Mar
2009) | 25 lines
Changed paths:
M
http://src.chromium.org/viewvc/chrome/trunk/src/net/http/http_auth.h?r1=12635&r2=12634
M
http://src.chromium.org/viewvc/chrome/trunk/src/net/http/http_cache.cc?r1=12635&r2=12634
M
http://src.chromium.org/viewvc/chrome/trunk/src/net/http/http_network_transaction.cc?r1=12635&r2=12634
M
http://src.chromium.org/viewvc/chrome/trunk/src/net/http/http_network_transaction.h?r1=12635&r2=12634
M
http://src.chromium.org/viewvc/chrome/trunk/src/net/http/http_network_transaction_unittest.cc?r1=12635&r2=12634
M
http://src.chromium.org/viewvc/chrome/trunk/src/net/http/http_transaction.h?r1=12635&r2=12634
M
http://src.chromium.org/viewvc/chrome/trunk/src/net/http/http_transaction_unittest.h?r1=12635&r2=12634
M
http://src.chromium.org/viewvc/chrome/trunk/src/net/http/http_util.cc?r1=12635&r2=12634
M
http://src.chromium.org/viewvc/chrome/trunk/src/net/http/http_util.h?r1=12635&r2=12634
M
http://src.chromium.org/viewvc/chrome/trunk/src/net/http/http_util_unittest.cc?r1=12635&r2=12634
M
http://src.chromium.org/viewvc/chrome/trunk/src/net/tools/testserver/testserver.py?r1=12635&r2=12634
M
http://src.chromium.org/viewvc/chrome/trunk/src/net/url_request/url_request.cc?r1=12635&r2=12634
M
http://src.chromium.org/viewvc/chrome/trunk/src/net/url_request/url_request_http_job.cc?r1=12635&r2=12634
M
http://src.chromium.org/viewvc/chrome/trunk/src/net/url_request/url_request_http_job.h?r1=12635&r2=12634
M
http://src.chromium.org/viewvc/chrome/trunk/src/net/url_request/url_request_unittest.cc?r1=12635&r2=12634
Respect cookies set in a 401 responses when restarting the http transaction.
There are two parts to this change:
(1) rebuild the request cookies before each transaction restart for
authentication
(2) notify the URLRequestHttpJob of header completion before *each*
transaction restart for authentication
By "each transaction" I mean the automatic restarts that don't require
user input, such as:
- replying to the first step of NTLM
- selecting identity embedded in URL
- selecting identity in auth-cache
Needing to notify URLRequestHttpJob for these intermediate restarts is
a consequence of cookie store management being done outside of
HttpNetworkTransaction.
After updating the cookie store, URLRequestHttpJob now tests
|HttpTransaction::IsReadyToRestartForAuth()| to check whether the
notification was informational or an identity is actually needed.
R=wtc
BUG=6450
Review URL: http://codereview.chromium.org/51004
------------------------------------------------------------------------
--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings
--~--~---------~--~----~------------~-------~--~----~
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/group/chromium-bugs
-~----------~----~----~----~------~----~------~--~---
