Comment #3 on issue 6731 by bugdro...@chromium.org: We should have unit tests for the SafeBrowsingBlockingPage class http://code.google.com/p/chromium/issues/detail?id=6731
The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=13088
------------------------------------------------------------------------
r13088 | jcam...@chromium.org | 2009-04-03 10:18:04 -0700 (Fri, 03 Apr
2009) | 13 lines
Changed paths:
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/renderer_host/mock_render_process_host.cc?r1=13088&r2=13087
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/safe_browsing/safe_browsing_blocking_page.cc?r1=13088&r2=13087
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/safe_browsing/safe_browsing_blocking_page.h?r1=13088&r2=13087
A
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/safe_browsing/safe_browsing_blocking_page_unittest.cc
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/safe_browsing/safe_browsing_service.cc?r1=13088&r2=13087
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/safe_browsing/safe_browsing_service.h?r1=13088&r2=13087
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tab_contents/interstitial_page.cc?r1=13088&r2=13087
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tab_contents/interstitial_page.h?r1=13088&r2=13087
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tab_contents/web_contents_unittest.cc?r1=13088&r2=13087
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/unit/unittests.vcproj?r1=13088&r2=13087
This CL adds unit-tests for the SafeBrowsingBlockingPage class.
This required:
- creating a factory to create SafeBrowsingBlockingPage
instances (so unit-tests can provide their own sub-classes).
- making the code posts tasks on the current message loop
when there is no IO thread. This should only happen in
tests scenarios where we only have 1 thread.
BUG=6731
TEST=Run the unit-tests. In Chrome, navigate to pages flagged as malware
(ex: ianfette.org) and make sure the safe browsing feature still works as
expected.
Review URL: http://codereview.chromium.org/56135
------------------------------------------------------------------------
--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings
--~--~---------~--~----~------------~-------~--~----~
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/group/chromium-bugs
-~----------~----~----~----~------~----~------~--~---
