Comment #6 on issue 9310 by bugdro...@chromium.org: Progress circle does  
not immediately appear when navigating away from new tab
http://code.google.com/p/chromium/issues/detail?id=9310

The following revision refers to this bug:
     http://src.chromium.org/viewvc/chrome?view=rev&revision=13131

------------------------------------------------------------------------
r13131 | bre...@chromium.org | 2009-04-04 10:55:46 -0700 (Sat, 04 Apr 2009)  
| 10 lines
Changed paths:
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/browser.cc?r1=13131&r2=13130
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/dom_ui/dom_ui_unittest.cc?r1=13131&r2=13130
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tab_contents/web_contents.cc?r1=13131&r2=13130
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tabs/tab_strip_model.cc?r1=13131&r2=13130
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tabs/tab_strip_model.h?r1=13131&r2=13130
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tabs/tab_strip_model_unittest.cc?r1=13131&r2=13130
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/tabs/dragged_tab_view.cc?r1=13131&r2=13130
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/tabs/tab_renderer.cc?r1=13131&r2=13130
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/tabs/tab_renderer.h?r1=13131&r2=13130
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/tabs/tab_strip.cc?r1=13131&r2=13130
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/tabs/tab_strip.h?r1=13131&r2=13130

Make the throbber throb sooner after you navigate. This fixes the new tab  
page,
which would not start throbbing until the load committed. I think this was  
always
broken, but switching the tab contents types covered it up.

Now I have a flag that goes along with the tab updating that indicates if  
it's
a load update or a full update. This is necessary to avoid updating the  
title
to the page's URL until it does actually commit.

BUG=9310
Review URL: http://codereview.chromium.org/60066
------------------------------------------------------------------------


--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings

--~--~---------~--~----~------------~-------~--~----~
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/group/chromium-bugs
-~----------~----~----~----~------~----~------~--~---

Reply via email to