Status: Available Owner: ---- CC: mar...@chromium.org Labels: Type-Feature Pri-2 OS-All Area-BrowserUI Size-Medium Area-DevTools Maintainability Tests HelpWanted
New issue 9764 by mar...@chromium.org: Move most in-process browser tests into "ChromeTest.dll" to fix adhoc singleton issue http://code.google.com/p/chromium/issues/detail?id=9764 [From Darin] A better design for the in-browser unit tests would be to redesign them to work more like a normal browser. Instead of trying to restart BrowserMain, we should go all the way back to ChromeMain and unload chrome.dll. To make that work, perhaps we could bake the unit tests and the Chrome code into a ChromeTest.dll. Then we could load that before each test, and invoke its ChromeMain with a special command line flag that would magically invoke the corresponding test. With some cleverness we could probably make this work. Then advantage is that we would have a clean Chrome for each test without having to teach Chrome how to do something (namely, shutting down and restarting without unloading) it never needs to know how to do otherwise. It seems way to fragile (read: recipe for flakiness) to try to patch all of the odd statics. --- Let's define chrometest.dll which is roughly chrome.dll with additional code backed in in it to support --run_inbrowser_test=int and an export to return the number of available tests. It also includes test code. browser_tests.exe is a really thin console app that repeatedly loads and unloads chrometest.dll and calls ChromeMain() with --run_inbrowser_test=N. Sounds simple? -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~---------~--~----~------------~-------~--~----~ Automated mail from issue updates at http://crbug.com/ Subscription options: http://groups.google.com/group/chromium-bugs -~----------~----~----~----~------~----~------~--~---
