Updates:
Summary: Cannot use Page Up & Page Down while using the "search in
page" featureComment #4 on issue 7079 by bugdro...@chromium.org: Cannot use Page Up & Page Down while using the "search in page" feature http://code.google.com/p/chromium/issues/detail?id=7079 The following revision refers to this bug: http://src.chromium.org/viewvc/chrome?view=rev&revision=13389 ------------------------------------------------------------------------ r13389 | fin...@chromium.org | 2009-04-08 16:38:16 -0700 (Wed, 08 Apr 2009) | 10 lines Changed paths: M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/renderer_host/render_view_host.cc?r1=13389&r2=13388 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/renderer_host/render_view_host.h?r1=13389&r2=13388 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/renderer_host/render_widget_host.cc?r1=13389&r2=13388 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/renderer_host/render_widget_host.h?r1=13389&r2=13388 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/bookmark_editor_view.h?r1=13389&r2=13388 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/bookmark_manager_view.cc?r1=13389&r2=13388 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/bookmark_manager_view.h?r1=13389&r2=13388 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/bug_report_view.cc?r1=13389&r2=13388 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/bug_report_view.h?r1=13389&r2=13388 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/edit_keyword_controller.cc?r1=13389&r2=13388 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/edit_keyword_controller.h?r1=13389&r2=13388 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/find_bar_view.cc?r1=13389&r2=13388 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/find_bar_view.h?r1=13389&r2=13388 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/find_bar_win.cc?r1=13389&r2=13388 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/find_bar_win.h?r1=13389&r2=13388 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/input_window.cc?r1=13389&r2=13388 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/new_profile_dialog.h?r1=13389&r2=13388 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/options/cookies_view.cc?r1=13389&r2=13388 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/options/cookies_view.h?r1=13389&r2=13388 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/options/general_page_view.cc?r1=13389&r2=13388 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/options/general_page_view.h?r1=13389&r2=13388 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/shelf_item_dialog.h?r1=13389&r2=13388 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/render_messages_internal.h?r1=13389&r2=13388 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/render_view.cc?r1=13389&r2=13388 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/render_view.h?r1=13389&r2=13388 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/render_widget.cc?r1=13389&r2=13388 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/render_widget.h?r1=13389&r2=13388 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/views/controls/text_field.cc?r1=13389&r2=13388 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/views/controls/text_field.h?r1=13389&r2=13388 M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/glue/webview.h?r1=13389&r2=13388 M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/glue/webview_impl.cc?r1=13389&r2=13388 M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/glue/webview_impl.h?r1=13389&r2=13388 When the Find bar has focus it eats keypresses such as PageUp, PageDown and Up and Down arrow keys. It doesn't need to - instead the page should scroll even if focus is on the Find bar. This patch forwards those selected keypresses to the page for its perusal. Known issues: Just like Firefox, the page doesn't scroll if it has frames. SONG=I like to fixit fixit. I like to fixit fixit. BUG=7079 TEST=Open FindInPage on a webpage that has a vertical scrollbar. Press Down, Up, PageDown and PageUp and the page should scroll accordingly. Make sure no ding is heard while doing so. Also make sure this works if focus is on a textfield/textarea when you press Ctrl+F. Review URL: http://codereview.chromium.org/62129 ------------------------------------------------------------------------ -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~---------~--~----~------------~-------~--~----~ Automated mail from issue updates at http://crbug.com/ Subscription options: http://groups.google.com/group/chromium-bugs -~----------~----~----~----~------~----~------~--~---
