Comment #8 on issue 9324 by o...@chromium.org: run_webkit_tests should  
implement per test timeout
http://code.google.com/p/chromium/issues/detail?id=9324

OK. I have a much simpler suggestion. We should make the test timeout be 5  
seconds
instead of 10 seconds. Then we should had a SLOW modifier to webkit tests.  
Tests
marked as slow get 10x the regular timeout (so 50 seconds by default). If a  
test is
slow, we mark it as slow. If a test occasionally or always times out no  
matter the
size of the timeout, we mark it as timing out, but not slow. A test cannot  
be marked
slow and timeout.

Overall, this should considerably improve the performance of  
run_webkit_tests because
tests that actually timeout will only take 5 seconds now. Also, this will  
mean that
tests that are just slow (e.g. acid3) won't need to be marked as timeout.

Also, in terms of implementation is this considerably easier than per-test  
timeouts.
We can just create a test_shell instance with this longer timeout and move  
all the
slow tests to be run on that instance.

Back of the envelope math suggests we'd save about a minute (~10%) for each  
run of
Windows Release on the bots.

Pam, I can take this bug off your hands if you'd like.

--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings

--~--~---------~--~----~------------~-------~--~----~
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/group/chromium-bugs
-~----------~----~----~----~------~----~------~--~---

Reply via email to