Comment #13 on issue 7319 by [email protected]: Characters in the UI
are too small in Malayalam (ml) and Bengali (bn) Chrome
http://code.google.com/p/chromium/issues/detail?id=7319
The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=13773
------------------------------------------------------------------------
r13773 | [email protected] | 2009-04-15 12:16:10 -0700 (Wed, 15 Apr 2009)
| 20 lines
Changed paths:
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/resources/locale_settings.grd?r1=13773&r2=13772
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/resources/locale_settings_ar.xtb?r1=13773&r2=13772
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/resources/locale_settings_bg.xtb?r1=13773&r2=13772
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/resources/locale_settings_bn.xtb?r1=13773&r2=13772
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/resources/locale_settings_ca.xtb?r1=13773&r2=13772
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/resources/locale_settings_cs.xtb?r1=13773&r2=13772
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/resources/locale_settings_da.xtb?r1=13773&r2=13772
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/resources/locale_settings_de.xtb?r1=13773&r2=13772
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/resources/locale_settings_el.xtb?r1=13773&r2=13772
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/resources/locale_settings_en-GB.xtb?r1=13773&r2=13772
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/resources/locale_settings_es-419.xtb?r1=13773&r2=13772
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/resources/locale_settings_es.xtb?r1=13773&r2=13772
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/resources/locale_settings_et.xtb?r1=13773&r2=13772
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/resources/locale_settings_fi.xtb?r1=13773&r2=13772
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/resources/locale_settings_fil.xtb?r1=13773&r2=13772
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/resources/locale_settings_fr.xtb?r1=13773&r2=13772
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/resources/locale_settings_gu.xtb?r1=13773&r2=13772
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/resources/locale_settings_he.xtb?r1=13773&r2=13772
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/resources/locale_settings_hi.xtb?r1=13773&r2=13772
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/resources/locale_settings_hr.xtb?r1=13773&r2=13772
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/resources/locale_settings_hu.xtb?r1=13773&r2=13772
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/resources/locale_settings_id.xtb?r1=13773&r2=13772
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/resources/locale_settings_it.xtb?r1=13773&r2=13772
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/resources/locale_settings_ja.xtb?r1=13773&r2=13772
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/resources/locale_settings_kn.xtb?r1=13773&r2=13772
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/resources/locale_settings_ko.xtb?r1=13773&r2=13772
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/resources/locale_settings_lt.xtb?r1=13773&r2=13772
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/resources/locale_settings_lv.xtb?r1=13773&r2=13772
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/resources/locale_settings_ml.xtb?r1=13773&r2=13772
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/resources/locale_settings_mr.xtb?r1=13773&r2=13772
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/resources/locale_settings_nb.xtb?r1=13773&r2=13772
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/resources/locale_settings_nl.xtb?r1=13773&r2=13772
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/resources/locale_settings_or.xtb?r1=13773&r2=13772
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/resources/locale_settings_pl.xtb?r1=13773&r2=13772
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/resources/locale_settings_pt-BR.xtb?r1=13773&r2=13772
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/resources/locale_settings_pt-PT.xtb?r1=13773&r2=13772
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/resources/locale_settings_ro.xtb?r1=13773&r2=13772
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/resources/locale_settings_ru.xtb?r1=13773&r2=13772
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/resources/locale_settings_sk.xtb?r1=13773&r2=13772
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/resources/locale_settings_sl.xtb?r1=13773&r2=13772
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/resources/locale_settings_sr.xtb?r1=13773&r2=13772
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/resources/locale_settings_sv.xtb?r1=13773&r2=13772
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/resources/locale_settings_ta.xtb?r1=13773&r2=13772
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/resources/locale_settings_te.xtb?r1=13773&r2=13772
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/resources/locale_settings_th.xtb?r1=13773&r2=13772
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/resources/locale_settings_tr.xtb?r1=13773&r2=13772
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/resources/locale_settings_uk.xtb?r1=13773&r2=13772
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/resources/locale_settings_vi.xtb?r1=13773&r2=13772
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/resources/locale_settings_zh-CN.xtb?r1=13773&r2=13772
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/resources/locale_settings_zh-TW.xtb?r1=13773&r2=13772
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/constrained_window_impl.cc?r1=13773&r2=13772
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/frame/opaque_browser_frame_view.cc?r1=13773&r2=13772
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/frame/opaque_browser_frame_view.h?r1=13773&r2=13772
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/sad_tab_view.cc?r1=13773&r2=13772
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/sad_tab_view.h?r1=13773&r2=13772
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/tabs/tab_renderer.cc?r1=13773&r2=13772
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/gfx/chrome_font_win.cc?r1=13773&r2=13772
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/l10n_util_win.cc?r1=13773&r2=13772
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/l10n_util_win.h?r1=13773&r2=13772
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/win_util.cc?r1=13773&r2=13772
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/views/controls/menu/chrome_menu.cc?r1=13773&r2=13772
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/views/controls/menu/menu.cc?r1=13773&r2=13772
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/views/controls/table/table_view.cc?r1=13773&r2=13772
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/views/controls/tree/tree_view.cc?r1=13773&r2=13772
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/views/widget/aero_tooltip_manager.cc?r1=13773&r2=13772
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/views/widget/tooltip_manager.cc?r1=13773&r2=13772
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/views/widget/tooltip_manager.h?r1=13773&r2=13772
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/views/window/custom_frame_view.cc?r1=13773&r2=13772
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/views/window/custom_frame_view.h?r1=13773&r2=13772
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/views/window/dialog_client_view.cc?r1=13773&r2=13772
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/views/window/dialog_client_view.h?r1=13773&r2=13772
For some Indian locales, the automatic font fallback by Windows UI
components leads to too tiny glyphs for UI strings. Therefore, this patch
makes it possible to override the UI font family and UI font size
localizable by adding two entries to locale_settings (IDS_UI_FONT_FAMILY
and IDS_UI_FONT_SIZE_SCALER - percentile scale).
It's is also to fix a P1 bug for Chrome 2.0 final (so this patch needs to
be merged back to the branch).
For most locales, the UI font family is set to 'default' and the UI font
size scaler is set to 100, which indicates that the UI font (menu, message,
etc) obtained from Windows will be used.
For ml and bn, it's set to the 'kartica' and 'vrinda' (the default Windows
fonts for those scripts) and the scaler is set to 150 and 160 respectively.
For Hindi and Telugu, only the font size scaler is set to 150.
When IDS_UI_FONT_FAMILY is 'default' and the scaler is 100, the behavior
will remain the same. When it's not, their values are used to create
ChromeFont (base and derived) and WindowsTitle font. In addition, menu will
be drawn by 'owner' (to override the windows font) and the font for table
view, tree and tooltip is also set to IDS_UI_FONT_FAMILY.
While working on this, I replaced all the instances of 'static ChromeFont'
with 'static ChromeFont*' and initialized them in a lazy manner.
The whole approach is still a hack necessary due to the size issue with the
default fonts for some Indic scripts on Windows. We'd not need this on
Linux and Mac.
TEST=1. Run chrome with '--lang=bn' or '--lang=ml' and see UI strings are
legible in menu, context menu, bookmark, bookmark manager, tooltips, and
tab titles. With '--lang=hi' and '--lang=te', the difference is not
dramatic but should be more readable. In other locales, it should remain
the same.
2.UI test in en-US locale should pass.
3. Running UI tests under Purify should not have any new leak.
BUG=7319
Review URL: http://codereview.chromium.org/62064
------------------------------------------------------------------------
--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings
--~--~---------~--~----~------------~-------~--~----~
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/group/chromium-bugs
-~----------~----~----~----~------~----~------~--~---
