Comment #2 on issue 9988 by [email protected]: [linux] resource bundle  
should own gdkpixbufs
http://code.google.com/p/chromium/issues/detail?id=9988

The following revision refers to this bug:
     http://src.chromium.org/viewvc/chrome?view=rev&revision=13847

------------------------------------------------------------------------
r13847 | [email protected] | 2009-04-16 09:52:36 -0700 (Thu, 16 Apr 2009) | 14  
lines
Changed paths:
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/base/gfx/gtk_util.cc?r1=13847&r2=13846
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/autocomplete/autocomplete_popup_view_gtk.cc?r1=13847&r2=13846
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gtk/bookmark_bar_gtk.cc?r1=13847&r2=13846
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gtk/bookmark_bar_gtk.h?r1=13847&r2=13846
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gtk/browser_toolbar_gtk.cc?r1=13847&r2=13846
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gtk/custom_button.cc?r1=13847&r2=13846
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gtk/download_item_gtk.cc?r1=13847&r2=13846
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gtk/download_shelf_gtk.cc?r1=13847&r2=13846
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gtk/gtk_chrome_button.cc?r1=13847&r2=13846
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gtk/infobar_gtk.cc?r1=13847&r2=13846
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gtk/nine_box.cc?r1=13847&r2=13846
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/resource_bundle.h?r1=13847&r2=13846
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/resource_bundle_linux.cc?r1=13847&r2=13846

Have ResourceBundle own GdkPixbufs.

This is the same as how ResourceBundle owns the SkBitmaps it loads.
This should be faster than before because ResourceBundle will only
load each bitmap once and cache the image.

Also fix a memory leak in GdkPixbufFromSkBitmap.

valgrind says we're not leaking here.

BUG=9988

Review URL: http://codereview.chromium.org/67179

------------------------------------------------------------------------


--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings

--~--~---------~--~----~------------~-------~--~----~
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/group/chromium-bugs
-~----------~----~----~----~------~----~------~--~---

Reply via email to