Comment #4 on issue 14654 by [email protected]: HTML5 Drag and drop,  
effectAllowed and dragEffect broken in Chrome.
http://code.google.com/p/chromium/issues/detail?id=14654

OK. I got "move" to work. The initial value for kDropTargetOperation does  
not contain DragOperationGeneric. DropOperationGeneric is used for move.

--- webkit/glue/webview_impl.cc (revision 17821)
+++ webkit/glue/webview_impl.cc (working copy)
@@ -137,7 +137,7 @@
  // The webcore drag operation type when something is trying to be dropped  
on
  // the webview.  These values are taken from Apple's windows port.
  static const WebCore::DragOperation kDropTargetOperation =
-    static_cast<WebCore::DragOperation>(DragOperationCopy |  
DragOperationLink);
+    static_cast<WebCore::DragOperation>(DragOperationCopy |  
DragOperationLink |
DragOperationGeneric);

  // AutocompletePopupMenuClient
  class AutocompletePopupMenuClient : public WebCore::PopupMenuClient {

The comment explains why Safari for Windows is having the exqact same  
problem.

However, we still never show the link, nor the move cursor. It turns out  
that we never return
DROPEFFECT_LINK nor DROPEFFECT_MOVE. GetPreferredDropEffect always returns  
DROPEFFECT_COPY because
we hard code to always use DROPEFFECT_COPY | DROPEFFECT_LINK in  
tab_contents_view_win.cc.

I think I've reached my limit for now. I'm not sure how the drop effect is  
supposed to get
propagated from the renderer to the browser thread.

--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings

--~--~---------~--~----~------------~-------~--~----~
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/group/chromium-bugs
-~----------~----~----~----~------~----~------~--~---

Reply via email to