Comment #13 on issue 11906 by [email protected]: PageActions API probably
wants a way to update fields temporarily
http://code.google.com/p/chromium/issues/detail?id=11906
When Nick and I discussed this the other day, we decided to punt on this
because the dynamic tooltip problem is orthogonal
to the problem at hand. However, when I think more about this, I've come to
the conclusion that maybe we shouldn't punt --
it could mean more headaches down the line. I propose we scrap option 1 and
instead change the manifest to specify icons as
a list:
"page_actions": [
{
"id": "myaction", // chosen by developer, and should be unique
within their extension
"name": "Do action",
"icons": ["favicon.gif", ...]
}
]
... then we can add two optional parameters to the enableForTab API, where
you can specify the icon_index to use and the
name to use (overrides the default). This change would apply for that
tab_id+url combination only.
void enableForTab(string pageActionId, {int tabId, string url, [int
icon_index], [string name]})
void disableForTab(string pageActionId, {int tabId, string url})
This way you have one page action, which can have multiple icon states and
different tooltips (and each tab has its own
different combinations).
Sound good?
--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings
--~--~---------~--~----~------------~-------~--~----~
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/group/chromium-bugs
-~----------~----~----~----~------~----~------~--~---
