Updates: Mergedinto: -14594 Comment #4 on issue 14600 by bugdro...@chromium.org: Crash - views::NativeMenuWin::UpdateStates() http://code.google.com/p/chromium/issues/detail?id=14600
The following revision refers to this bug: http://src.chromium.org/viewvc/chrome?view=rev&revision=19558 ------------------------------------------------------------------------ r19558 | b...@chromium.org | 2009-06-29 16:39:25 -0700 (Mon, 29 Jun 2009) | 8 lines Changed paths: M http://src.chromium.org/viewvc/chrome/trunk/src/views/controls/menu/native_menu_win.cc?r1=19558&r2=19557 Rework a loop in the native menu code to iterate over the vector of items we have, rather than the actual system menu. I believe this may fix a crash where the code indexes out of bounds in the vector. The trouble is the assumption that the native menu index matches the index into the vector. If someone has installed a windows addon this may not be true. It's safer to restrict the iteration to the bounds of the vector and index into the menu based on that. http://crbug.com/14600 TEST=none Review URL: http://codereview.chromium.org/150061 ------------------------------------------------------------------------ -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~---------~--~----~------------~-------~--~----~ Automated mail from issue updates at http://crbug.com/ Subscription options: http://groups.google.com/group/chromium-bugs -~----------~----~----~----~------~----~------~--~---