Comment #5 on issue 15531 by bugdro...@chromium.org: regression:
shift-space doesn't scroll the page backwards
http://code.google.com/p/chromium/issues/detail?id=15531
The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=19707
------------------------------------------------------------------------
r19707 | hb...@chromium.org | 2009-06-30 21:41:53 -0700 (Tue, 30 Jun 2009)
| 10 lines
Changed paths:
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.cc?r1=19707&r2=19706
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.h?r1=19707&r2=19706
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/native_web_keyboard_event.h?r1=19707&r2=19706
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/native_web_keyboard_event_linux.cc?r1=19707&r2=19706
M
http://src.chromium.org/viewvc/chrome/trunk/src/webkit/api/public/gtk/WebInputEventFactory.h?r1=19707&r2=19706
M
http://src.chromium.org/viewvc/chrome/trunk/src/webkit/api/src/gtk/WebInputEventFactory.cpp?r1=19707&r2=19706
A quick fix for Issue 15531 and 10953
This issue is caused by my another mistake that I forgot setting the
modifier-key state in creating a Char event in
RenderWidgetHostViewGtkWidget::ForwardCharEvent().
Since the GtkIMContext signal-handlers don't use GdkEventKey objects and
cannot get the modififer-key state, this change save the state in
RenderWidgetHostViewGtkWidget::KeyPressReleaseEvent() before dispatching a
key event to the GtkIMContext object.
Also, this change adds gtk_im_context_focus_in() and
gtk_im_context_focus_out() calls to fix compatibility problems with ibus.
BUG=10953 "IME support"
BUG=15531 "regression: shift-space doesn't scroll the page backwards"
TEST=Open a test page in <http://crbug.com/15531>, press shift+space keys,
and observe ev.shiftKey is true.
Review URL: http://codereview.chromium.org/151010
------------------------------------------------------------------------
--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings
--~--~---------~--~----~------------~-------~--~----~
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/group/chromium-bugs
-~----------~----~----~----~------~----~------~--~---
