Comment #2 on issue 15648 by bugdro...@chromium.org: Move ResourceFetcher and related usage out of WebFrame http://code.google.com/p/chromium/issues/detail?id=15648
The following revision refers to this bug: http://src.chromium.org/viewvc/chrome?view=rev&revision=19742 ------------------------------------------------------------------------ r19742 | da...@chromium.org | 2009-07-01 10:12:55 -0700 (Wed, 01 Jul 2009) | 30 lines Changed paths: M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/navigation_state.h?r1=19742&r2=19741 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/render_view.cc?r1=19742&r2=19741 M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/api/public/WebData.h?r1=19742&r2=19741 M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/api/public/WebFrame.h?r1=19742&r2=19741 M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/api/public/WebURLRequest.h?r1=19742&r2=19741 M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/api/src/WebURLRequest.cpp?r1=19742&r2=19741 M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/glue/bookmarklet_unittest.cc?r1=19742&r2=19741 M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/glue/cpp_bound_class_unittest.cc?r1=19742&r2=19741 M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/glue/devtools/dom_agent_unittest.cc?r1=19742&r2=19741 M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/glue/dom_serializer_unittest.cc?r1=19742&r2=19741 M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/glue/glue_util.cc?r1=19742&r2=19741 M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/glue/glue_util.h?r1=19742&r2=19741 M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/glue/webframe.h?r1=19742&r2=19741 M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/glue/webframe_impl.cc?r1=19742&r2=19741 M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/glue/webframe_impl.h?r1=19742&r2=19741 M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/glue/webframe_unittest.cc?r1=19742&r2=19741 M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/glue/webframeloaderclient_impl.cc?r1=19742&r2=19741 M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/tools/test_shell/plugin_tests.cc?r1=19742&r2=19741 M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/tools/test_shell/test_shell.cc?r1=19742&r2=19741 M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/tools/test_shell/test_webview_delegate.cc?r1=19742&r2=19741 Add Reload and LoadData methods to WebFrame. LoadData replaces LoadAlternateHTMLString, changing types to WebKit API types and allowing for more flexibility (supports loading non-HTML data). LoadHTMLString is modified to support some optional parameters. Note: Since WebFrame is going to soon be part of the WebKit API, it is OK style-wise for it to use optional parameters. This patch also includes a change to remove the securityInfo property from WebURLRequest. I did this so that I could eliminate the need to pass a WebURLRequest to LoadData / LoadHTMLString. This also fixes a TODO of mine to eliminate this field on WebCore::ResourceRequest since securityInfo (SSL cert info) is really more of a response property. It was only part of the request as a hack to support certain error pages. I work around that by leveraging NavigationState in chrome/renderer. I added some templatized, implicit constructors to WebData for convenience. I plan to make similar changes to WebCString and WebString in a future CL. This CL is a incremental step toward moving ResourceFetcher out of WebFrame. BUG=15648 TEST=none R=dglazkov Review URL: http://codereview.chromium.org/150146 ------------------------------------------------------------------------ -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~---------~--~----~------------~-------~--~----~ Automated mail from issue updates at http://crbug.com/ Subscription options: http://groups.google.com/group/chromium-bugs -~----------~----~----~----~------~----~------~--~---