Comment #2 on issue 15259 by [email protected]: New  
FtpNetworkTransaction doesn't handle short reads well
http://code.google.com/p/chromium/issues/detail?id=15259

The following revision refers to this bug:
     http://src.chromium.org/viewvc/chrome?view=rev&revision=19954

------------------------------------------------------------------------
r19954 | [email protected] | 2009-07-06 09:49:51 -0700 (Mon, 06 Jul  
2009) | 11 lines
Changed paths:
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/net/base/io_buffer.cc?r1=19954&r2=19953
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/net/ftp/ftp_network_transaction.cc?r1=19954&r2=19953
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/net/ftp/ftp_network_transaction.h?r1=19954&r2=19953
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/net/ftp/ftp_network_transaction_unittest.cc?r1=19954&r2=19953

Make new FtpNetworkTransaction handle short reads correctly.

The problem was that some functions were parsing response lines, but  
without checking that they have the entire line available.

This change will also make it easier to handle multi-line greeting (230  
welcome messages). I plan to do that afterwards.

TEST=Covered by net_unittests.

http://crbug.com/15259

Review URL: http://codereview.chromium.org/149043
------------------------------------------------------------------------


--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings

--~--~---------~--~----~------------~-------~--~----~
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/group/chromium-bugs
-~----------~----~----~----~------~----~------~--~---

Reply via email to