Comment #11 on issue 13902 by [email protected]: [HTML5-Video] Video  
element doesn't work when running Chrome on Vista64
http://code.google.com/p/chromium/issues/detail?id=13902

The following revision refers to this bug:
     http://src.chromium.org/viewvc/chrome?view=rev&revision=20455

------------------------------------------------------------------------
r20455 | [email protected] | 2009-07-10 19:41:16 -0700 (Fri, 10 Jul  
2009) | 11 lines
Changed paths:
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/media/base/pipeline_impl.cc?r1=20455&r2=20454
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/media/base/pipeline_impl.h?r1=20455&r2=20454
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/media/base/pipeline_impl_unittest.cc?r1=20455&r2=20454

More media::PipelineImpl cleanup, this time focusing on not taking down the  
render process.

Specifically, if the pipeline hasn't started we should fail gracefully and  
not DCHECK.  Volume and playback rate are now allowed to be set if the  
pipeline isn't running, and filters will now receive a call to SetVolume()  
and SetPlaybackRate() with the initial values when the pipeline has fully  
initialized.

Added tests and expectations for all of this and ran valgrind to verify  
that we were indeed leaking memory (now fixed).

BUG=16009, 13902
TEST=media_unittests, layout tests

Review URL: http://codereview.chromium.org/149500

------------------------------------------------------------------------


--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings

--~--~---------~--~----~------------~-------~--~----~
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/group/chromium-bugs
-~----------~----~----~----~------~----~------~--~---

Reply via email to