Comment #11 on issue 8381 by bugdro...@chromium.org: Hook up Bookmark Bar http://code.google.com/p/chromium/issues/detail?id=8381
The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=20591
------------------------------------------------------------------------
r20591 | j...@chromium.org | 2009-07-13 17:58:17 -0700 (Mon, 13 Jul 2009) |
32 lines
Changed paths:
A
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/nibs/en.lproj/BookmarkBar.xib
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/nibs/en.lproj/Toolbar.xib?r1=20591&r2=20590
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/bookmark_bar_bridge.h?r1=20591&r2=20590
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/bookmark_bar_bridge.mm?r1=20591&r2=20590
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/bookmark_bar_bridge_unittest.mm?r1=20591&r2=20590
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/bookmark_bar_controller.h?r1=20591&r2=20590
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/bookmark_bar_controller.mm?r1=20591&r2=20590
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/bookmark_bar_controller_unittest.mm?r1=20591&r2=20590
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/bookmark_bar_view.h?r1=20591&r2=20590
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/bookmark_bar_view.mm?r1=20591&r2=20590
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/bookmark_bar_view_unittest.mm?r1=20591&r2=20590
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/bookmark_button_cell.mm?r1=20591&r2=20590
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/bookmark_button_cell_unittest.mm?r1=20591&r2=20590
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/gradient_button_cell.h?r1=20591&r2=20590
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/gradient_button_cell.mm?r1=20591&r2=20590
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/gradient_button_cell_unittest.mm?r1=20591&r2=20590
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/tab_window_controller.mm?r1=20591&r2=20590
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/toolbar_controller.h?r1=20591&r2=20590
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/toolbar_controller.mm?r1=20591&r2=20590
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/toolbar_controller_unittest.mm?r1=20591&r2=20590
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/chrome.gyp?r1=20591&r2=20590
More bookmark bar changes.
* Applied memory cleanliness fix in unit test; follow-up from
http://codereview.chromium.org/149308.
* Move bookmark bar into it's own nib; minor code refactor to
accomodate.
* The toolbar STAR button somehow lost it's action; added it back in.
* Implemented delete bookmark notification callback so we behave
(remove button from the screen) when a bookmark is deleted.
* Added context menus for the bookmark bar and bookmark buttons.
* Hooked up a handful of these menu items. E.g.
- open in new tab, window, incog window
- delete bookmark (finally)
- bookmark manager (which then hits a NOTIMPLEMENTED())
- always show bookmark bar
* Truncate bookmark button text on end, not on middle.
Experimental to look more like Windows.
It looks cleaner but is less Mac-like.
* Add "draws border when mouse goes over" for bookmark buttons. Need
to do it by hand since we have a custom button drawing method.
BUG=crbug.com/8381
TEST=Here's a list:
- Make sure the bookmark buttons don't have a border unless the mouse is
over them
- Toolbar "STAR" should now add bookmarks when clicked
- Test context menus on bookmark buttons, and the bar itself
- Confirm a few of the behaviors as listed in the 'what I hooked up'; e.g.
Right click on bookmark --> delete menu item should delete button
Review URL: http://codereview.chromium.org/155358
------------------------------------------------------------------------
--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings
--~--~---------~--~----~------------~-------~--~----~
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/group/chromium-bugs
-~----------~----~----~----~------~----~------~--~---
