Comment #5 on issue 15738 by bugdro...@chromium.org: No connectivity with system proxy settings http://code.google.com/p/chromium/issues/detail?id=15738
The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=20605
------------------------------------------------------------------------
r20605 | arin...@chromium.org | 2009-07-13 22:23:30 -0700 (Mon, 13 Jul
2009) | 7 lines
Changed paths:
M
http://src.chromium.org/viewvc/chrome/trunk/src/net/proxy/proxy_config.cc?r1=20605&r2=20604
M
http://src.chromium.org/viewvc/chrome/trunk/src/net/proxy/proxy_config.h?r1=20605&r2=20604
M
http://src.chromium.org/viewvc/chrome/trunk/src/net/proxy/proxy_config_service_common_unittest.cc?r1=20605&r2=20604
M
http://src.chromium.org/viewvc/chrome/trunk/src/net/proxy/proxy_config_service_common_unittest.h?r1=20605&r2=20604
M
http://src.chromium.org/viewvc/chrome/trunk/src/net/proxy/proxy_config_service_linux.cc?r1=20605&r2=20604
M
http://src.chromium.org/viewvc/chrome/trunk/src/net/proxy/proxy_config_service_win_unittest.cc?r1=20605&r2=20604
M
http://src.chromium.org/viewvc/chrome/trunk/src/net/proxy/proxy_config_unittest.cc?r1=20605&r2=20604
M
http://src.chromium.org/viewvc/chrome/trunk/src/net/proxy/proxy_list.cc?r1=20605&r2=20604
M
http://src.chromium.org/viewvc/chrome/trunk/src/net/proxy/proxy_server.cc?r1=20605&r2=20604
M
http://src.chromium.org/viewvc/chrome/trunk/src/net/proxy/proxy_server.h?r1=20605&r2=20604
M
http://src.chromium.org/viewvc/chrome/trunk/src/net/proxy/proxy_server_unittest.cc?r1=20605&r2=20604
M
http://src.chromium.org/viewvc/chrome/trunk/src/net/proxy/proxy_service.cc?r1=20605&r2=20604
M
http://src.chromium.org/viewvc/chrome/trunk/src/net/proxy/proxy_service_unittest.cc?r1=20605&r2=20604
Whenever proxy configurations contain socks and http/https/ftp proxies,
socks configuration over rid the other proxies. Fixes the issue. Attached
test cases.
BUG=15738
TEST=unittest (ProxyConfigTest.ParseProxyRules,
ProxyServiceTest.DefaultProxyFallbackToSOCKS)
Review URL: http://codereview.chromium.org/149191
------------------------------------------------------------------------
--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings
--~--~---------~--~----~------------~-------~--~----~
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/group/chromium-bugs
-~----------~----~----~----~------~----~------~--~---
