Comment #7 on issue 13936 by [email protected]: Implement extension specific events http://code.google.com/p/chromium/issues/detail?id=13936
The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=20714
------------------------------------------------------------------------
r20714 | [email protected] | 2009-07-14 20:24:36 -0700 (Tue, 14 Jul 2009)
| 11 lines
Changed paths:
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_browser_event_router.cc?r1=20714&r2=20713
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_browser_event_router.h?r1=20714&r2=20713
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_event_names.cc?r1=20714&r2=20713
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_event_names.h?r1=20714&r2=20713
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_function_dispatcher.cc?r1=20714&r2=20713
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_process_manager.cc?r1=20714&r2=20713
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_process_manager.h?r1=20714&r2=20713
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/location_bar_view.cc?r1=20714&r2=20713
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/render_messages_internal.h?r1=20714&r2=20713
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/extensions/extension_process_bindings.cc?r1=20714&r2=20713
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/extensions/extension_process_bindings.h?r1=20714&r2=20713
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/render_thread.cc?r1=20714&r2=20713
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/render_thread.h?r1=20714&r2=20713
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/renderer_resources.grd?r1=20714&r2=20713
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/resources/extension_process_bindings.js?r1=20714&r2=20713
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/data/extensions/samples/subscribe_page_action/background.html?r1=20714&r2=20713
D
/trunk/src/chrome/test/data/extensions/samples/subscribe_page_action/feed-icon-16x16-subscribed.png
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/data/extensions/samples/subscribe_page_action/manifest.json?r1=20714&r2=20713
EFD now notifies EPM of renderviews created, which in turn notifies the
renderer of page actions that it knows about.
Remove generic event "page-action-executed" in favor of page action
specific event (sent as extension_id/page_action_id).
In the bindings, we now setup events for each page action we know about so
we can register for specific events, and not receive broadcast events from
all page actions. To setup these events I added a GetCurrentPageActions()
to extension_process_bindings.cc and a helper function
GetCurrentExtensionId().
And, finally, I simplified the page action background page by removing the
check to see if we are already subscribed to the feed (since we now support
multiple feed readers, it doesn't make sense anymore to always check Google
Reader). This check might make a comeback later in a different form.
BUG=13936
TEST=The RSS sample extension should work as before.
Review URL: http://codereview.chromium.org/155514
------------------------------------------------------------------------
--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings
--~--~---------~--~----~------------~-------~--~----~
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/group/chromium-bugs
-~----------~----~----~----~------~----~------~--~---
